Don't handle unitless length quirk in CSS parser fast path

Don't handle unitless length quirk in CSS parser fast path

This patch makes the CSS parser fast path reject unitless length (aside
from 0 and presentational svg attributes). The quirks mode spec allows
unitless lengths on a fixed set of CSS properties, which we correctly
handle inside the (full) property parser. Currently we will allow any
unitless lengths for any fast path length property when quirks mode is
enabled, instead of the smaller set where it is supposed to apply.

As quirks-mode is not a common case, we just don't support the unitless
length quirk at all in the fast path.

This patch also extends the property-parsing-test helper to allow for
quirks-mode-only values (which are rejected by CSS.supports) and also
fixes the test description for properties with hyphens.

https://quirks.spec.whatwg.org/#the-unitless-length-quirk

BUG=436145
Committed: https://crrev.com/a7764c8c92fca51d53e7129e601c3b8b9e7bffce
Cr-Commit-Position: refs/heads/master@{#361619}

[Timothy Loh, 2015-11-25 05:02:28]

Description was changed from

==========
Don't handle unitless length quirk in CSS parser fast path

This patch makes the CSS parser fast path reject unitless length (aside
from 0 and presentational svg attributes). The quirks mode spec allows
unitless lengths on a fixed set of CSS properties, which we correctly
handle inside the (full) property parser. Currently we will allow any
unitless lengths for any fast path length property when quirks mode is
enabled, instead of the smaller set where it is supposed to apply.

As quirks-mode is not a common case, we don't need to handle this in
the fast path.

This patch also extends the property-parsing-test helper to allow for
quirks-mode-only values (which are rejected by CSS.supports) and also
fixes the test description for properties with hyphens.

https://quirks.spec.whatwg.org/#the-unitless-length-quirk
==========

to

==========
Don't handle unitless length quirk in CSS parser fast path

This patch makes the CSS parser fast path reject unitless length (aside
from 0 and presentational svg attributes). The quirks mode spec allows
unitless lengths on a fixed set of CSS properties, which we correctly
handle inside the (full) property parser. Currently we will allow any
unitless lengths for any fast path length property when quirks mode is
enabled, instead of the smaller set where it is supposed to apply.

As quirks-mode is not a common case, we don't need to handle this in
the fast path.

This patch also extends the property-parsing-test helper to allow for
quirks-mode-only values (which are rejected by CSS.supports) and also
fixes the test description for properties with hyphens.

https://quirks.spec.whatwg.org/#the-unitless-length-quirk

BUG=436145
==========

[Timothy Loh, 2015-11-25 05:02:28]

timloh@chromium.org changed reviewers:
+ alancutter@chromium.org, rune@opera.com

[Timothy Loh, 2015-11-25 05:02:57]

Description was changed from

==========
Don't handle unitless length quirk in CSS parser fast path

This patch makes the CSS parser fast path reject unitless length (aside
from 0 and presentational svg attributes). The quirks mode spec allows
unitless lengths on a fixed set of CSS properties, which we correctly
handle inside the (full) property parser. Currently we will allow any
unitless lengths for any fast path length property when quirks mode is
enabled, instead of the smaller set where it is supposed to apply.

As quirks-mode is not a common case, we don't need to handle this in
the fast path.

This patch also extends the property-parsing-test helper to allow for
quirks-mode-only values (which are rejected by CSS.supports) and also
fixes the test description for properties with hyphens.

https://quirks.spec.whatwg.org/#the-unitless-length-quirk

BUG=436145
==========

to

==========
Don't handle unitless length quirk in CSS parser fast path

This patch makes the CSS parser fast path reject unitless length (aside
from 0 and presentational svg attributes). The quirks mode spec allows
unitless lengths on a fixed set of CSS properties, which we correctly
handle inside the (full) property parser. Currently we will allow any
unitless lengths for any fast path length property when quirks mode is
enabled, instead of the smaller set where it is supposed to apply.

As quirks-mode is not a common case, we just don't support the unitless
length quirk at all in the fast path.

This patch also extends the property-parsing-test helper to allow for
quirks-mode-only values (which are rejected by CSS.supports) and also
fixes the test description for properties with hyphens.

https://quirks.spec.whatwg.org/#the-unitless-length-quirk

BUG=436145
==========

[Timothy Loh, 2015-11-25 05:04:36]

I chose to add a new test instead of updating
fast/css/parsing-unitless-length-quirk.html since this way the existing test can
be kept fairly consistent.

[alancutter (OOO until 2018), 2015-11-25 05:26:35]

lgtm

[Timothy Loh, 2015-11-25 10:41:14]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2015-11-25 10:41:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1475903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1475903002/1

[commit-bot: I haz the power, 2015-11-25 10:46:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-25 10:47:36]

Patchset 1 (id:??) landed as
https://crrev.com/a7764c8c92fca51d53e7129e601c3b8b9e7bffce
Cr-Commit-Position: refs/heads/master@{#361619}