callTheAdoptionAgency should work asynchronously

Source/core/html/parser/HTMLConstructionSite.cpp

 /*
  * Copyright (C) 2010 Google, Inc. All Rights Reserved.
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 65 matching lines @@
         || item->hasTagName(pTag)
         || item->hasTagName(rpTag)
         || item->hasTagName(rtTag);
 }
 
 static inline bool isAllWhitespace(const String& string)
 {
     return string.isAllSpecialCharacters<isHTMLSpace>();
 }
 
-static inline void executeInsertTask(HTMLConstructionSiteTask& task)
+static inline void insert(HTMLConstructionSiteTask& task)
 {
-    ASSERT(task.operation == HTMLConstructionSiteTask::Insert);
-
     if (task.parent->hasTagName(templateTag))
         task.parent = toHTMLTemplateElement(task.parent.get())->content();
 
+    if (ContainerNode* parent = task.child->parentNode())
+        parent->parserRemoveChild(task.child.get());
+
     if (task.nextChild)
         task.parent->parserInsertBefore(task.child.get(), task.nextChild.get());
     else
         task.parent->parserAppendChild(task.child.get());
 
     // JavaScript run from beforeload (or DOM Mutation or event handlers)
     // might have removed the child, in which case we should not attach it.
 
     if (task.child->parentNode() && task.parent->attached() && !task.child->attached())
         task.child->attach();
+}
+
+static inline void executeInsertTask(HTMLConstructionSiteTask& task)
+{
+    ASSERT(task.operation == HTMLConstructionSiteTask::Insert);
+
+    insert(task);
 
     task.child->beginParsingChildren();
 
     if (task.selfClosing)
         task.child->finishParsingChildren();
 }
 
 static inline void executeReparentTask(HTMLConstructionSiteTask& task)
 {
     ASSERT(task.operation == HTMLConstructionSiteTask::Reparent);
 
     if (ContainerNode* parent = task.child->parentNode())
         parent->parserRemoveChild(task.child.get());
 
     task.parent->parserAppendChild(task.child);
 
     if (task.child->parentElement()->attached() && !task.child->attached())
         task.child->lazyAttach();
 }
 
+static inline void executeInsertAgainTask(HTMLConstructionSiteTask& task)
+{
+    ASSERT(task.operation == HTMLConstructionSiteTask::InsertAgain);
+
+    insert(task);
+}
+
+static inline void executeTakeAllChildrenTask(HTMLConstructionSiteTask& task)
+{
+    ASSERT(task.operation == HTMLConstructionSiteTask::TakeAllChildren);
+
+    // It's sort of ugly, but we store the |oldParent| in the |child| field
+    // of the task so that we don't bloat the HTMLConstructionSiteTask
+    // object in the common case of the Insert operation.
+    ContainerNode* oldParent = static_cast<ContainerNode*>(task.child.get());

[eseidel, 2013/05/07 00:11:37]

The only thing I would change here is making this private to the Task object. 
Then it can do the ASSERTing, etc.

+
+    task.parent->takeAllChildrenFrom(oldParent);
+    // Notice that we don't need to manually attack the moved children

[eseidel, 2013/05/07 00:11:37]

attack!

+    // because takeAllChildrenFrom does that work for us.
+}
+
 static inline void executeTask(HTMLConstructionSiteTask& task)
 {
     if (task.operation == HTMLConstructionSiteTask::Insert)
         return executeInsertTask(task);
 
+    if (task.operation == HTMLConstructionSiteTask::InsertAgain)

[eseidel, 2013/05/07 00:11:37]

I would put a comment that these below this comment are only for the adoption
agency.

+        return executeInsertAgainTask(task);
+
     if (task.operation == HTMLConstructionSiteTask::Reparent)
         return executeReparentTask(task);
 
+    if (task.operation == HTMLConstructionSiteTask::TakeAllChildren)
+        return executeTakeAllChildrenTask(task);
+
     ASSERT_NOT_REACHED();
 }
 
 void HTMLConstructionSite::attachLater(ContainerNode* parent, PassRefPtr<Node> prpChild, bool selfClosing)
 {
     ASSERT(scriptingContentIsAllowed(m_parserContentPolicy) || !prpChild.get()->isElementNode() || !toScriptElementIfPossible(toElement(prpChild.get())));
     ASSERT(pluginContentIsAllowed(m_parserContentPolicy) || !prpChild->isPluginElement());
 
     HTMLConstructionSiteTask task(HTMLConstructionSiteTask::Insert);
     task.parent = parent;
@@ skipping 401 matching lines @@
 }
 
 void HTMLConstructionSite::reparent(HTMLElementStack::ElementRecord* newParent, HTMLElementStack::ElementRecord* child)
 {
     HTMLConstructionSiteTask task(HTMLConstructionSiteTask::Reparent);
     task.parent = newParent->element();
     task.child = child->element();
     m_taskQueue.append(task);
 }
 
+void HTMLConstructionSite::reparent(HTMLElementStack::ElementRecord* newParent, HTMLStackItem* child)
+{
+    HTMLConstructionSiteTask task(HTMLConstructionSiteTask::Reparent);
+    task.parent = newParent->element();
+    task.child = child->element();
+    m_taskQueue.append(task);
+}
+
+void HTMLConstructionSite::insertAgain(HTMLStackItem* newParent, HTMLElementStack::ElementRecord* child)

[eseidel, 2013/05/07 00:11:37]

Need a name so that folks have a prayer of knowing what this does.

+{
+    if (newParent->causesFosterParenting()) {
+        fosterParent(child->element());
+        return;
+    }
+
+    HTMLConstructionSiteTask task(HTMLConstructionSiteTask::InsertAgain);
+    task.parent = newParent->element();
+    task.child = child->element();
+    m_taskQueue.append(task);
+}
+
+void HTMLConstructionSite::takeAllChildren(HTMLStackItem* newParent, HTMLElementStack::ElementRecord* oldParent)
+{
+    HTMLConstructionSiteTask task(HTMLConstructionSiteTask::TakeAllChildren);
+    task.parent = newParent->element();
+    task.child = oldParent->element();
+    m_taskQueue.append(task);
+}
+
 PassRefPtr<Element> HTMLConstructionSite::createElement(AtomicHTMLToken* token, const AtomicString& namespaceURI)
 {
     QualifiedName tagName(nullAtom, token->name(), namespaceURI);
     RefPtr<Element> element = ownerDocumentForCurrentNode()->createElement(tagName, true);
     setAttributes(element.get(), token, m_parserContentPolicy);
     return element.release();
 }
 
 inline Document* HTMLConstructionSite::ownerDocumentForCurrentNode()
 {
@@ skipping 120 matching lines @@
 {
     HTMLConstructionSiteTask task(HTMLConstructionSiteTask::Insert);
     findFosterSite(task);
     task.child = node;
     ASSERT(task.parent);
 
     m_taskQueue.append(task);
 }
 
 }