Source/core/rendering/RenderBox.cpp - Issue 14759010: Fix the float logic to not return an anonymous block ancestor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.cpp

Issue 14759010: Fix the float logic to not return an anonymous block ancestor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update as per Julien's comments. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderBox.cpp

diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp

index c61b1550b4cf4ff80fe2730faf714e914f443e8c..10f624b35634c34456c09df9ca0106d9162fdbb7 100644

--- a/Source/core/rendering/RenderBox.cpp

+++ b/Source/core/rendering/RenderBox.cpp

@@ -186,7 +186,7 @@ void RenderBox::removeFloatingOrPositionedChildFromBlockLists()

for (RenderObject* curr = parent(); curr && !curr->isRenderView(); curr = curr->parent()) {

if (curr->isRenderBlock()) {

RenderBlock* currBlock = toRenderBlock(curr);

- if (!parentBlock || currBlock->containsFloat(this))

+ if (!parentBlock || parentBlock->isAnonymousBlock() || currBlock->containsFloat(this))

parentBlock = currBlock;

}