LayoutTests/fast/block/float/float-not-removed-crash2.html - Issue 14759010: Fix the float logic to not return an anonymous block ancestor

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/block/float/float-not-removed-crash2.html

Issue 14759010: Fix the float logic to not return an anonymous block ancestor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update as per Julien's comments. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <html>
	Julien - ping for review 2013/05/07 18:43:20 DOCTYPE per favor! DOCTYPE per favor!
	2 <body style="display: -webkit-flex;">

	3 <i>

	4 <div> </div><row>

	5 <source id=test style="float: right; -webkit-padding-before: 238px;">A</source>
	Julien - ping for review 2013/05/07 18:43:20 s/-webkit-padding-before/padding-top/ (just remove s/-webkit-padding-before/padding-top/ (just remove it as these extra style as I wouldn't expect that to impact anything).
	6 </i>

	7 <div style="-webkit-logical-height: 188;"></div>
	Julien - ping for review 2013/05/07 18:43:20 s/-webkit-logical-height/height/ s/-webkit-logical-height/height/
	8 <style>

	9 .class1 {

	10 -webkit-logical-width: 51667px;
	Julien - ping for review 2013/05/07 18:43:20 s/-webkit-logical-width/width/ s/-webkit-logical-width/width/
	11 }

	12 </style>

	13 <script>

	14 if (window.testRunner)

	15 testRunner.dumpAsText();

	16

	17 function reference(domNode) {

	18 this.domNode = domNode;

	19 }
	Julien - ping for review 2013/05/07 18:43:20 This wrapper is useless and should be removed. This wrapper is useless and should be removed.
	20

	21 function walk(a, currentPrefix, index, domNode) {
	Julien - ping for review 2013/05/07 18:43:20 walk() is overly complicated for no good reason. C walk() is overly complicated for no good reason. Can't we just collect the nodes in a breadth-first search without using some random key (that is a series of '_')?
	22 if (domNode == null)

	23 return;

	24 newPrefix = currentPrefix + "_" + index;

	25 walk(a, currentPrefix, index + 1, domNode.nextSibling);

	26 walk(a, newPrefix, 0, domNode.firstChild);

	27 a[newPrefix] = new reference(domNode);

	28 }

	29

	30 function clear() {

	31 var a = new Array();

	32 walk(a, "", 0, document.documentElement);

	33 for(key in a) {

	34 a[key].domNode.parentNode.removeChild(a[key].domNode);

	35 if (document.documentElement)

	36 document.documentElement.offsetTop;

	37 }

	38 }

	39

	40 document.documentElement.offsetTop;

	41 test.setAttribute("class", "class1");

	42 document.documentElement.offsetTop;

	43 clear();

	44 alert("PASS. WebKit didn't crash.");

	45 </script>

	46 </body>

	47 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/block/float/float-not-removed-crash2-expected.txt » ('j') | Source/core/rendering/RenderBlock.cpp » ('J')