LayoutTests/fast/block/float/float-not-removed-crash2.html - Issue 14759010: Fix the float logic to not return an anonymous block ancestor

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/block/float/float-not-removed-crash2.html

Issue 14759010: Fix the float logic to not return an anonymous block ancestor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <body style="display: -webkit-flex; ">

	2 <foobar>

	3 <figure> ]V 8[</figure><row><source id=test style="float: right; -webkit-pad ding-before: 238px; ">></foobar>>>>><listing style="-webkit-logical-height: 188; ">
	Julien - ping for review 2013/05/07 00:51:22 Can't we reduce this test case even more? Some di Can't we reduce this test case even more? Some directions: * Removing some of the random content (or at least replacing it with something more readable). * Removing some of the style properties by better ones (like -webkit-logical-height is height as we are in an horizontal writing mode) * The JS could be beautified.
	4 <style>

	5 .class1 {

	6 -webkit-logical-width: 51667px;

	7 }

	8 </style><script>

	9 if (window.testRunner)

	10 testRunner.dumpAsText();

	11

	12 function reference(domNode) {

	13 this.domNode = domNode;

	14 }

	15

	16 function walk(a, currentPrefix, index, domNode) {

	17 if (domNode == null)

	18 return;

	19 newPrefix = currentPrefix + "_" + index;

	20 walk(a, currentPrefix, index + 1, domNode.nextSibling);

	21 walk(a, newPrefix, 0, domNode.firstChild);

	22 a[newPrefix] = new reference(domNode);

	23 }

	24

	25 function clear() {

	26 var a = new Array();

	27 walk(a, "", 0, document.documentElement);

	28 for(key in a) {

	29 a[key].domNode.parentNode.removeChild(a[key].domNode);

	30 if (document.documentElement)

	31 document.documentElement.offsetTop;

	32 }

	33 }

	34

	35 document.documentElement.offsetTop;

	36 test.setAttribute("class", "class1");

	37 document.documentElement.offsetTop;

	38 clear();

	39 alert("PASS. WebKit didn't crash.");

	40 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/block/float/float-not-removed-crash2-expected.txt » ('j') | Source/core/rendering/RenderBox.cpp » ('J')