chrome/browser/ui/sync/one_click_signin_helper.cc - Issue 14759008: Making the condition for showing signin in one click case more general.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 14759008: Making the condition for showing signin in one click case more general. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/sync/one_click_signin_helper.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc

index 3891458ac6285e26cb4c26b6caf5f4ff9194c315..6a7cff7f62ba33dbcec10e5f476fa8e24af00553 100644

--- a/chrome/browser/ui/sync/one_click_signin_helper.cc

+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc

@@ -316,7 +316,8 @@ bool AreWeShowingSignin(GURL url, SyncPromoUI::Source source,

return (url.ReplaceComponents(replacements) == clean_login_url &&

source != SyncPromoUI::SOURCE_UNKNOWN) ||

- (url.ReplaceComponents(replacements) == clean_one_click_url &&

+ (IsValidGaiaSigninRedirectOrResponseURL(url) &&

+ url.spec().find("ChromeLoginPrompt") != std::string::npos &&

!email.empty());

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »