third_party/WebKit/LayoutTests/http/tests/security/mixedContent/filesystem-url-in-iframe.html - Issue 1475863005: [Async][WIP] Call FrameLoader::checkCompleted() asynchronously to avoid sync body.onload()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/security/mixedContent/filesystem-url-in-iframe.html

Issue 1475863005: [Async][WIP] Call FrameLoader::checkCompleted() asynchronously to avoid sync body.onload() Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/isolatedWorld/bypass-main-world-csp-for-inline-style-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-in-body-onload-sync-to-invalid-cross-origin-response-handling.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/security/mixedContent/filesystem-url-in-iframe.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/filesystem-url-in-iframe.html b/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/filesystem-url-in-iframe.html

index 5b6e64162478ccba9740d0413886d9f8577fd6b3..014be426db743b91557d4d4e612a16d5d5ce707d 100644

--- a/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/filesystem-url-in-iframe.html

+++ b/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/filesystem-url-in-iframe.html

@@ -19,10 +19,6 @@ if (location.protocol != 'https:')

location = 'https://127.0.0.1:8443/security/mixedContent/filesystem-url-in-iframe.html';

else {

var iframe = document.querySelector('iframe');

- iframe.onload = function () {

- if (window.testRunner)

- testRunner.notifyDone();

- };

// Opening a file system with temporary storage

window.webkitRequestFileSystem(TEMPORARY, 1024*1024 /*1MB*/, function(fs) {

@@ -30,6 +26,10 @@ else {

fileEntry.createWriter(function(fileWriter) {

fileWriter.onwriteend = function(e) {

alert('PASS (1/2): File written');

+ iframe.onload = function () {

+ if (window.testRunner)

+ testRunner.notifyDone();

+ };

iframe.src = fileEntry.toURL('text/html');

};