Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4850)

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 1475863005: [Async][WIP] Call FrameLoader::checkCompleted() asynchronously to avoid sync body.onload() Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_browsertest.cc
diff --git a/chrome/browser/extensions/extension_browsertest.cc b/chrome/browser/extensions/extension_browsertest.cc
index ace18cd3c5d163a22bd734cf5daa15690fb3d91f..5f841d9c5dc1e7659719ff58e0a286de4deed7d6 100644
--- a/chrome/browser/extensions/extension_browsertest.cc
+++ b/chrome/browser/extensions/extension_browsertest.cc
@@ -587,7 +587,7 @@ void ExtensionBrowserTest::OpenWindow(content::WebContents* contents,
content::WebContents** newtab_result) {
content::WindowedNotificationObserver windowed_observer(
content::NOTIFICATION_LOAD_STOP,
- content::NotificationService::AllSources());
+ content::Source<content::NavigationController>(&contents->GetController()));
ASSERT_TRUE(content::ExecuteScript(contents,
"window.open('" + url.spec() + "');"));
@@ -618,7 +618,8 @@ void ExtensionBrowserTest::NavigateInRenderer(content::WebContents* contents,
bool result = false;
content::WindowedNotificationObserver windowed_observer(
content::NOTIFICATION_LOAD_STOP,
- content::NotificationService::AllSources());
+ content::Source<content::NavigationController>(&contents->GetController()));
+ //content::NotificationService::AllSources());
ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
contents,
"window.addEventListener('unload', function() {"
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698