Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1475863002: Copy the passed in name string into the os_thread structure and delete it in the destructor. (Closed)

Created:
5 years ago by siva
Modified:
5 years ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Copy the passed in name string into the os_thread structure and delete it in the destructor. R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/569b3f77eeee1f2c710b13076eb731b7bafbad9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M runtime/vm/os_thread.h View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/os_thread.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
siva
5 years ago (2015-11-25 00:57:54 UTC) #2
Ivan Posva
LGTM -ip
5 years ago (2015-11-25 02:48:14 UTC) #3
siva
5 years ago (2015-11-25 17:23:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
569b3f77eeee1f2c710b13076eb731b7bafbad9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698