chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html - Issue 1475843002: [MR] Add description field to MediaSink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

Issue 1475843002: [MR] Add description field to MediaSink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css ('K') | « chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css ('k') | chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js » ('j') | chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

diff --git a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

index f3c93a3c4fcb06ca12cada7c20ca430932bd15a8..1f9530cddf51425b07cd681bc18447d975be101d 100644

--- a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

+++ b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

@@ -89,10 +89,11 @@

</div>

- <div class="sink-text route"

- hidden$="[[computeRouteInSinkListHidden_(item.id, sinkToRouteMap_)]]">

- <span>[[computeRouteInSinkListValue_(item.id, sinkToRouteMap_)]]</span>

- </div>

+ <template is="dom-if" if="[[!computeSinkSubtextHidden_(item, sinkToRouteMap_)]]">

apacible 2015/11/25 23:05:41 nit: Does the "if=...>" fit on the next line?

imcheng 2015/12/01 19:29:27 Done.

+ <div class="sink-subtext">

+ <span>[[computeSinkSubtext_(item, sinkToRouteMap_)]]</span>

+ </div>

+ </template>

</div>

</paper-item>