Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1475823003: [runtime] First step to sanitize regexp literal creation. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
oth, Michael Lippautz, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] First step to sanitize regexp literal creation. This is the initial step towards refactoring the regexp literation creation code to make it less obscure and more similar to the mechanism we use to create array and object literals. There's now a new runtime entry %CreateRegExpLiteral with the same interface as the entries for array and object literals, except that we still pass the flags as string. Instead of embedding the hand written native to clone JSRegExp instances we now have a FastCloneRegExpStub, which behaves similar to the other FastCloneShallowArrayStub and FastCloneShallowObjectStub that we already had. R=mlippautz@chromium.org, yangguo@chromium.org Committed: https://crrev.com/09b44428e4d37ce3b8264148bef5ff4b156d47df Cr-Commit-Position: refs/heads/master@{#32255}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -1370 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 2 chunks +0 lines, -24 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +0 lines, -146 lines 0 comments Download
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +11 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +56 lines, -0 lines 1 comment Download
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +0 lines, -70 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +6 lines, -43 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +6 lines, -41 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +5 lines, -46 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +6 lines, -43 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +6 lines, -43 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +6 lines, -43 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +5 lines, -46 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +5 lines, -46 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +1 line, -1 line 0 comments Download
M src/runtime/runtime-literals.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Benedikt Meurer
5 years ago (2015-11-25 08:42:51 UTC) #1
Benedikt Meurer
Michael: Please check changes to heap. Orion: Please check changes to interpreter. Yang: Please review ...
5 years ago (2015-11-25 08:44:23 UTC) #3
Michael Lippautz
heap/ lgtm
5 years ago (2015-11-25 08:49:02 UTC) #4
oth
interpreter lgtm. code shinkage great.
5 years ago (2015-11-25 08:58:39 UTC) #5
Yang
LGTM! Awesome. https://codereview.chromium.org/1475823003/diff/1/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/1475823003/diff/1/src/code-stubs-hydrogen.cc#newcode441 src/code-stubs-hydrogen.cc:441: // so that it doesn't build and ...
5 years ago (2015-11-25 09:06:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475823003/1
5 years ago (2015-11-25 09:17:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 09:22:44 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-25 09:23:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09b44428e4d37ce3b8264148bef5ff4b156d47df
Cr-Commit-Position: refs/heads/master@{#32255}

Powered by Google App Engine
This is Rietveld 408576698