Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 1475823002: [Sync] TypedUrlSyncableServiceTest tests leave junk in TEMP directory (Closed)

Created:
5 years ago by Gang Wu
Modified:
5 years ago
Reviewers:
sky, M-A Ruel
CC:
chromium-reviews, M-A Ruel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ScopedTempDir to create test folder instead of "TypedUrlSyncableServiceTest". BUG=561083 Committed: https://crrev.com/048e458c51a2ee397725d5bb54300db7efed215c Cr-Commit-Position: refs/heads/master@{#361687}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M components/history/core/browser/typed_url_syncable_service_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Gang Wu
Please take a look.
5 years ago (2015-11-25 02:56:47 UTC) #5
sky
LGTM
5 years ago (2015-11-25 17:10:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475823002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475823002/40001
5 years ago (2015-11-25 17:13:06 UTC) #10
M-A Ruel
Thanks a lot for addressing this quickly. A quick grep of CreateNewTempDirectory() shows a lot ...
5 years ago (2015-11-25 17:24:09 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years ago (2015-11-25 17:29:51 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-25 17:30:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/048e458c51a2ee397725d5bb54300db7efed215c
Cr-Commit-Position: refs/heads/master@{#361687}

Powered by Google App Engine
This is Rietveld 408576698