Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 14758005: [OTS] Fix WOFF2 decode error (Closed)

Created:
7 years, 7 months ago by Kunihiko Sakamoto
Modified:
7 years, 7 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, raph
Visibility:
Public.

Description

[OTS] Fix WOFF2 decode error Fix a bug that woff2 decoder fails to reconstruct glyf table when glyf table of original file was aligned to 2-byte boundaries. Before this patch, ReconstructGlyf() aligned glyf entries to 4-byte boundaries (which is a recommendation of the OpenType format, but not required). But the encoder stores original size of glyf table into woff2 header, so reconstructed glyf table become larger than the expected size, and cause decode error. This patch makes ReconstructGlyf() to generate 2-byte aligned glyf table. R=yusukes@chromium.org Committed: 101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/ots.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/woff2.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Kunihiko Sakamoto
Yusuke-san, could you take a look?
7 years, 7 months ago (2013-05-08 02:38:03 UTC) #1
Yusuke Sato
lgtm
7 years, 7 months ago (2013-05-08 03:16:55 UTC) #2
Kunihiko Sakamoto
7 years, 7 months ago (2013-05-08 03:39:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r101 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698