Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 14758003: GM: now that we use MD5 instead of CityHash, the JSON should say so (Closed)

Created:
7 years, 7 months ago by epoger
Modified:
7 years, 7 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

GM: now that we use MD5 instead of CityHash, the JSON should say so (this should have been part of https://code.google.com/p/skia/source/detail?r=8992 ) R=bungeman@google.com Committed: https://code.google.com/p/skia/source/detail?r=9038

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -65 lines) Patch
M gm/gm_expectations.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/gm_expectations.cpp View 6 chunks +23 lines, -15 lines 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-images/output-expected/json-summary.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-json/output-expected/json-summary.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-images/output-expected/json-summary.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-json/output-expected/json-summary.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-images/output-expected/json-summary.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-json/output-expected/json-summary.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/ignore-expectations-mismatch/output-expected/json-summary.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/intentionally-skipped-tests/output-expected/json-summary.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/no-readpath/output-expected/json-summary.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/tests/outputs/nonverbose/output-expected/json-summary.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/pipe-playback-failure/output-expected/json-summary.txt View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
epoger
Ready for review at patchset 1.
7 years, 7 months ago (2013-05-03 21:57:54 UTC) #1
bungeman-skia
Why not. LGTM
7 years, 7 months ago (2013-05-04 04:07:46 UTC) #2
epoger
7 years, 7 months ago (2013-05-07 15:52:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r9038 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698