Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 1475793003: Reland "[Interpreter] Add CreateClosure to BytecodeGraphBuilder." (Closed)

Created:
5 years ago by oth
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[Interpreter] Add CreateClosure to BytecodeGraphBuilder." Original issue's description: > [Interpreter] Add CreateClosure to BytecodeGraphBuilder. > > Adds code and tests to support CreateClosure bytecode when building > graphs. > > Committed: https://crrev.com/4cceb11b0929abcbc82bf0854554a9b66003335d > Cr-Commit-Position: refs/heads/master@{#32224} BUG=v8:4280 LOG=N Committed: https://crrev.com/6a8db006e1f0a08a43446b62765bba39fdc6af10 Cr-Commit-Position: refs/heads/master@{#32257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -92 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +14 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +16 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 30 chunks +49 lines, -74 lines 0 comments Download
M test/unittests/compiler/bytecode-graph-builder-unittest.cc View 4 chunks +52 lines, -2 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 2 chunks +5 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 3 chunks +60 lines, -0 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475793003/1
5 years ago (2015-11-25 09:00:00 UTC) #2
oth
Benedikt: can you take a quick look? This landed just after a change to Factory::NewSharedFunctionInfo ...
5 years ago (2015-11-25 09:10:42 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-25 09:24:25 UTC) #6
Benedikt Meurer
LGTM.
5 years ago (2015-11-25 09:24:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475793003/1
5 years ago (2015-11-25 09:50:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 09:51:50 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6a8db006e1f0a08a43446b62765bba39fdc6af10 Cr-Commit-Position: refs/heads/master@{#32257}
5 years ago (2015-11-25 09:51:56 UTC) #11
Michael Achenbach
5 years ago (2015-11-25 11:03:45 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1469303006/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks cfi:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds....

Powered by Google App Engine
This is Rietveld 408576698