Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Unified Diff: base/basictypes.h

Issue 1475783002: Remove kint8min, kint8max, and kint16min. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/audio_bus.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/basictypes.h
diff --git a/base/basictypes.h b/base/basictypes.h
index e167466ffe219275e62985806679f2c0896f1c74..e6d62858904ed223a111ef9d1917e8d46d3d1b18 100644
--- a/base/basictypes.h
+++ b/base/basictypes.h
@@ -2,12 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// This file contains definitions of our old basic integral types
-// ((u)int{8,16,32,64}) and further includes. I recommend that you use the C99
-// standard types instead, and include <stdint.h>/<stddef.h>/etc. as needed.
-// Note that the macros and macro-like constructs that were formerly defined in
-// this file are now available separately in base/macros.h.
-
#ifndef BASE_BASICTYPES_H_
#define BASE_BASICTYPES_H_
@@ -18,7 +12,8 @@
#include "base/macros.h"
#include "build/build_config.h"
-// DEPRECATED: Please use (u)int{8,16,32,64}_t instead (and include <stdint.h>).
+// DEPRECATED: Use (u)int{8,16,32,64}_t instead (and include <stdint.h>).
+// http://crbug.com/138542
typedef int8_t int8;
typedef uint8_t uint8;
typedef int16_t int16;
@@ -28,15 +23,13 @@ typedef uint32_t uint32;
typedef int64_t int64;
typedef uint64_t uint64;
-// DEPRECATED: Please use std::numeric_limits (from <limits>) or
+// DEPRECATED: Use std::numeric_limits (from <limits>) or
// (U)INT{8,16,32,64}_{MIN,MAX} in case of globals (and include <stdint.h>).
+// http://crbug.com/138542
const uint8 kuint8max = 0xFF;
const uint16 kuint16max = 0xFFFF;
const uint32 kuint32max = 0xFFFFFFFF;
const uint64 kuint64max = 0xFFFFFFFFFFFFFFFFULL;
-const int8 kint8min = -0x7F - 1;
-const int8 kint8max = 0x7F;
-const int16 kint16min = -0x7FFF - 1;
const int16 kint16max = 0x7FFF;
const int32 kint32min = -0x7FFFFFFF - 1;
const int32 kint32max = 0x7FFFFFFF;
« no previous file with comments | « no previous file | media/base/audio_bus.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698