Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1475773002: Add context_utils.h includes where needed. (Closed)

Created:
5 years ago by Torne
Modified:
5 years ago
CC:
chromium-reviews, qsr+mojo_chromium.org, zea+watch_chromium.org, vmpstr+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-sensors_chromium.org, yzshen+watch_chromium.org, bondd+autofillwatch_chromium.org, scheib+watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, ben+mojo_chromium.org, mlamouri+watch-media_chromium.org, cbentzel+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, aboxhall+watch_chromium.org, lcwu+watch_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Peter Beverloo, je_julie, darin-cc_chromium.org, jkarlin+watch_chromium.org, halliwell+watch_chromium.org, penghuang+watch-mandoline_chromium.org, vabr+watchlistautofill_chromium.org, android-webview-reviews_chromium.org, yfriedman+watch_chromium.org, mlamouri+watch-content_chromium.org, rouslan+autofill_chromium.org, mlamouri+watch-notifications_chromium.org, toyoshim+midi_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, timvolodine, asvitkine+watch_chromium.org, Michael van Ouwerkerk, gunsch+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, klundberg+watch_chromium.org, jochen+watch_chromium.org, rjkroege, mlamouri+watch-test-runner_chromium.org, plundblad+watch_chromium.org, riju_, nektar+watch_chromium.org, mcasas+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, Aaron Boodman, mikecase+watch_chromium.org, dtseng+watch_chromium.org, estade+watch_chromium.org, darin (slow to review), jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add context_utils.h includes where needed. base::android::GetApplicationContext is now defined in context_utils.h. Update includes for files that use this, and stop including it in jni_android.h. BUG=552419 TBR=jochen@chromium.org,sky@chromium.org,xhwang@chromium.org,davidben@chromium.org,tedchoc@chromium.org,scheib@chromium.org,qinmin@chromium.org,halliwell@chromium.org,thakis@chromium.org Committed: https://crrev.com/da6e7c9eab6317710168ba6a2588f68621c8668f Cr-Commit-Position: refs/heads/master@{#361701}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -9 lines) Patch
M android_webview/native/android_protocol_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/android/apk_assets.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/android/build_info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/android/content_uri_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/android/jni_android.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/android/memory_pressure_listener_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/android/path_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/test_file_util_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/accessibility_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/background_sync_launcher_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_application.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/data_usage/external_data_use_observer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/dev_tools_server.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/intent_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/net/external_estimate_provider_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/signin/account_management_screen_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/webapps/webapp_registry.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/invalidation/profile_invalidation_provider_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/android/router/media_router_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/android/router/media_router_dialog_controller_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/notifications/notification_ui_manager_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/signin/oauth2_token_service_delegate_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/speech/tts_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/app/android/crash_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/base/android/system_time_change_notifier_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/base/chromecast_config_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/gcm_driver/gcm_driver_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/invalidation/impl/invalidation_service_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/android/android_hooks.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/service_tab_launcher/browser/android/service_tab_launcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/variations/android/variations_seed_bridge.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/background_sync_network_observer_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/child_process_launcher_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/composited_touch_handle_drawable.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/download_controller_android_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/device_sensors/sensor_manager_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/geolocation/location_api_adapter_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/media/android/media_resource_getter_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/media/android/media_session.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/media/android/media_throttler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/mojo/service_registrar_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/speech/speech_recognizer_impl_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/time_zone_monitor_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/vr/android/cardboard/cardboard_vr_device.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/android/wrappers.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/services/core_services/android_hooks.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/android/audio_manager_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/media_player_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_player_bridge.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/webaudio_media_codec_bridge.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/capture/video/android/video_capture_device_factory_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/midi/midi_manager_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/midi/usb_midi_device_factory_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/android/android_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/android_hooks.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/android/network_change_notifier_delegate_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/android/network_library.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/x509_util_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_service_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M testing/android/native_test/native_test_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/android/window_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/clipboard/clipboard_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/clipboard/clipboard_android_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/device_form_factor_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/touch/touch_device_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/android/shared_device_display_info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/android/view_configuration.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/platform_window/android/platform_window_android.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Torne
Yaron, the only "real" change here is in base/android/jni_android.h - everything else is just fixing ...
5 years ago (2015-11-24 18:03:37 UTC) #2
Yaron
lgtm
5 years ago (2015-11-24 18:37:39 UTC) #3
Torne
jam@, can I get a top-level OWNER approval for all the #include rewrites?
5 years ago (2015-11-25 11:12:19 UTC) #5
jam
On 2015/11/25 11:12:19, Torne wrote: > jam@, can I get a top-level OWNER approval for ...
5 years ago (2015-11-25 16:25:42 UTC) #6
Torne
On 2015/11/25 16:25:42, jam wrote: > On 2015/11/25 11:12:19, Torne wrote: > > jam@, can ...
5 years ago (2015-11-25 17:05:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475773002/1
5 years ago (2015-11-25 17:11:28 UTC) #10
Torne
TBRing OWNERS for mechanical #include rewrite
5 years ago (2015-11-25 17:15:54 UTC) #12
davidben
content and net lgtm
5 years ago (2015-11-25 17:33:45 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 18:25:58 UTC) #15
commit-bot: I haz the power
5 years ago (2015-11-25 18:27:33 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da6e7c9eab6317710168ba6a2588f68621c8668f
Cr-Commit-Position: refs/heads/master@{#361701}

Powered by Google App Engine
This is Rietveld 408576698