Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: extensions/common/async_event.cc

Issue 14757022: Add a non-blocking "OneShotEvent" class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: dcronin's comments; ExtensionSystem::ready; and WeakPtr support Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/async_event.cc
diff --git a/extensions/common/async_event.cc b/extensions/common/async_event.cc
new file mode 100644
index 0000000000000000000000000000000000000000..fd265b1195bb514631296c5778f68c93e284f88d
--- /dev/null
+++ b/extensions/common/async_event.cc
@@ -0,0 +1,66 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/common/async_event.h"
+
+#include "base/callback.h"
+#include "base/location.h"
+#include "base/message_loop/message_loop_proxy.h"
+#include "base/task_runner.h"
+
+using base::TaskRunner;
+
+namespace extensions {
+
+struct AsyncEvent::TaskInfo {
+ TaskInfo() {}
+ TaskInfo(const tracked_objects::Location& from_here,
+ const scoped_refptr<TaskRunner>& runner,
+ const base::Closure& task)
+ : from_here(from_here), runner(runner), task(task) {
+ CHECK(runner != NULL); // Detect mistakes with a decent stack frame.
+ }
+ tracked_objects::Location from_here;
+ scoped_refptr<TaskRunner> runner;
Matt Perry 2013/05/15 21:08:54 Is it kosher to hang on to a TaskRunner reference
Jeffrey Yasskin 2013/05/15 22:46:50 A MessageLoopProxy is definitely kosher. The other
+ base::Closure task;
+};
+
+AsyncEvent::AsyncEvent() : happened_(false) {}
+AsyncEvent::~AsyncEvent() {}
+
+void AsyncEvent::RunAfter(const tracked_objects::Location& from_here,
+ const base::Closure& task) const {
+ RunAfter(from_here, task, base::MessageLoopProxy::current());
+}
+
+void AsyncEvent::RunAfter(const tracked_objects::Location& from_here,
+ const base::Closure& task,
+ const scoped_refptr<TaskRunner>& runner) const {
+ DCHECK(thread_checker_.CalledOnValidThread());
+
+ if (has_happened()) {
+ runner->PostTask(from_here, task);
+ } else {
+ tasks_.push_back(TaskInfo(from_here, runner, task));
+ }
+}
+
+void AsyncEvent::MarkHappened() {
+ DCHECK(thread_checker_.CalledOnValidThread());
+
+ CHECK(!happened_) << "Only call MarkHappened once.";
+
+ happened_ = true;
+ // After this point, a call to RunAfter() from one of the queued
+ // tasks could proceed immediately, but the fact that this object is
+ // single-threaded prevents that from being relevant.
+
+ // We could randomize tasks_ in debug mode in order to check that
+ // the order doesn't matter...
+ for (size_t i = 0; i < tasks_.size(); ++i) {
+ tasks_[i].runner->PostTask(tasks_[i].from_here, tasks_[i].task);
+ }
+}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698