Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Unified Diff: tests/untrusted_minidump/nacl.scons

Issue 14757008: Minidumper: Get the nexe's build ID from PT_NOTE when available (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Comment Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/untrusted_minidump/minidump_test.c ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/untrusted_minidump/nacl.scons
diff --git a/tests/untrusted_minidump/nacl.scons b/tests/untrusted_minidump/nacl.scons
index dba8b5a169f0a4f4499c790d43bc91de7f2869cc..712e48056fbc3acaca0b63a0e077323f17680994 100644
--- a/tests/untrusted_minidump/nacl.scons
+++ b/tests/untrusted_minidump/nacl.scons
@@ -11,6 +11,14 @@ if env.Bit('bitcode'):
if env.Bit('skip_nonstable_bitcode'):
Return()
+# Add a build ID to the nexe in the cases where this works.
+# TODO(mseaborn): Make "--build-id" work with the other toolchains.
+# * In the x86 nacl-gcc toolchain, "--build-id" produces a nexe that
+# sel_ldr won't load.
+# * pnacl-ld rejects "--build-id".
+if env.Bit('build_arm') and not env.Bit('bitcode'):
+ env.Append(LINKFLAGS=['-Wl,--build-id'])
+
nexe = env.ComponentProgram('minidump_test', 'minidump_test.c',
EXTRA_LIBS=['minidump_generator'])
« no previous file with comments | « tests/untrusted_minidump/minidump_test.c ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698