Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 14757004: Fix nacl-gdb so that it can read ELF core dump files (Closed)

Created:
7 years, 7 months ago by Mark Seaborn
Modified:
7 years, 7 months ago
Reviewers:
halyavin
CC:
native-client-reviews_googlegroups.com, bradn
Base URL:
http://git.chromium.org/native_client/nacl-gdb.git@master
Visibility:
Public.

Description

Fix nacl-gdb so that it can read ELF core dump files Before this change, nacl-gdb gives the error "no core file handler recognizes format" when given an ELF code dump file. Fix this by setting up the register layout for core dumps. Reuse the same layout as for Linux code dumps for interoperability. I tested this by producing a minidump from a NaCl minidump generator and converting it to an ELF core dump using Breakpad's minidump-2-core tool. While we could generate a different register layout (e.g. using NaCl's "struct NaClExceptionContext"), it's useful to keep the core dumps readable by regular Linux GDB. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3425 TEST=see above Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gdb.git;a=commit;h=9e993e0

Patch Set 1 #

Patch Set 2 : Cleanup: share code #

Patch Set 3 : Retry upload #

Patch Set 4 : Retry upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M gdb/amd64-linux-tdep.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gdb/amd64-linux-tdep.c View 1 2 chunks +9 lines, -4 lines 0 comments Download
M gdb/i386-linux-tdep.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gdb/i386-linux-tdep.c View 1 2 chunks +9 lines, -3 lines 0 comments Download
M gdb/nacl-tdep.c View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
Rietveld has some random failure when displaying some of the files here, so maybe you ...
7 years, 7 months ago (2013-05-08 03:35:05 UTC) #1
halyavin
On 2013/05/08 03:35:05, Mark Seaborn wrote: > Rietveld has some random failure when displaying some ...
7 years, 7 months ago (2013-05-08 20:15:08 UTC) #2
Mark Seaborn
7 years, 7 months ago (2013-05-08 22:31:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r9e993e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698