Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1475683002: ozone: Fix flow control regression in ARM swap buffers code path (Closed)

Created:
5 years ago by spang
Modified:
5 years ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Fix flow control regression in ARM swap buffers code path The early return after PostTaskAndReply() in GLSurfaceOzoneSurfaceless::SwapBuffersAsync was erroneously removed in f960a95 ("Split up synchronous & asynchronous swap buffers APIs"). This adds it back. It also removes the else after return; that's against the style guide. BUG=560553 TEST=boot chrome on veyron_jerry Committed: https://crrev.com/c63975ddfff98deaa93095cee0834ccf6b4c33ea Cr-Commit-Position: refs/heads/master@{#361349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/gl/gl_surface_ozone.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
5 years ago (2015-11-24 15:28:10 UTC) #2
alexst (slow to review)
lgtm
5 years ago (2015-11-24 15:39:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475683002/1
5 years ago (2015-11-24 15:41:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 16:08:19 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-24 16:09:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c63975ddfff98deaa93095cee0834ccf6b4c33ea
Cr-Commit-Position: refs/heads/master@{#361349}

Powered by Google App Engine
This is Rietveld 408576698