Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Side by Side Diff: PRESUBMIT.py

Issue 1475663002: [test] Add status-file presubmit check. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/presubmit.py » ('j') | tools/testrunner/local/statusfile.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 62
63 def _V8PresubmitChecks(input_api, output_api): 63 def _V8PresubmitChecks(input_api, output_api):
64 """Runs the V8 presubmit checks.""" 64 """Runs the V8 presubmit checks."""
65 import sys 65 import sys
66 sys.path.append(input_api.os_path.join( 66 sys.path.append(input_api.os_path.join(
67 input_api.PresubmitLocalPath(), 'tools')) 67 input_api.PresubmitLocalPath(), 'tools'))
68 from presubmit import CppLintProcessor 68 from presubmit import CppLintProcessor
69 from presubmit import SourceProcessor 69 from presubmit import SourceProcessor
70 from presubmit import CheckExternalReferenceRegistration 70 from presubmit import CheckExternalReferenceRegistration
71 from presubmit import CheckAuthorizedAuthor 71 from presubmit import CheckAuthorizedAuthor
72 from presubmit import CheckStatusFiles
72 73
73 results = [] 74 results = []
74 if not CppLintProcessor().Run(input_api.PresubmitLocalPath()): 75 if not CppLintProcessor().Run(input_api.PresubmitLocalPath()):
75 results.append(output_api.PresubmitError("C++ lint check failed")) 76 results.append(output_api.PresubmitError("C++ lint check failed"))
76 if not SourceProcessor().Run(input_api.PresubmitLocalPath()): 77 if not SourceProcessor().Run(input_api.PresubmitLocalPath()):
77 results.append(output_api.PresubmitError( 78 results.append(output_api.PresubmitError(
78 "Copyright header, trailing whitespaces and two empty lines " \ 79 "Copyright header, trailing whitespaces and two empty lines " \
79 "between declarations check failed")) 80 "between declarations check failed"))
80 if not CheckExternalReferenceRegistration(input_api.PresubmitLocalPath()): 81 if not CheckExternalReferenceRegistration(input_api.PresubmitLocalPath()):
81 results.append(output_api.PresubmitError( 82 results.append(output_api.PresubmitError(
82 "External references registration check failed")) 83 "External references registration check failed"))
84 if not CheckStatusFiles(input_api.PresubmitLocalPath()):
85 results.append(output_api.PresubmitError("Status file check failed"))
83 results.extend(CheckAuthorizedAuthor(input_api, output_api)) 86 results.extend(CheckAuthorizedAuthor(input_api, output_api))
84 return results 87 return results
85 88
86 89
87 def _CheckUnwantedDependencies(input_api, output_api): 90 def _CheckUnwantedDependencies(input_api, output_api):
88 """Runs checkdeps on #include statements added in this 91 """Runs checkdeps on #include statements added in this
89 change. Breaking - rules is an error, breaking ! rules is a 92 change. Breaking - rules is an error, breaking ! rules is a
90 warning. 93 warning.
91 """ 94 """
92 # We need to wait until we have an input_api object and use this 95 # We need to wait until we have an input_api object and use this
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 'v8_win64_rel': set(['defaulttests']), 293 'v8_win64_rel': set(['defaulttests']),
291 'v8_mac_rel': set(['defaulttests']), 294 'v8_mac_rel': set(['defaulttests']),
292 'v8_linux_arm_rel': set(['defaulttests']), 295 'v8_linux_arm_rel': set(['defaulttests']),
293 'v8_linux_arm64_rel': set(['defaulttests']), 296 'v8_linux_arm64_rel': set(['defaulttests']),
294 'v8_linux_mipsel_compile_rel': set(['defaulttests']), 297 'v8_linux_mipsel_compile_rel': set(['defaulttests']),
295 'v8_linux_mips64el_compile_rel': set(['defaulttests']), 298 'v8_linux_mips64el_compile_rel': set(['defaulttests']),
296 'v8_android_arm_compile_rel': set(['defaulttests']), 299 'v8_android_arm_compile_rel': set(['defaulttests']),
297 'v8_linux_chromium_gn_rel': set(['defaulttests']), 300 'v8_linux_chromium_gn_rel': set(['defaulttests']),
298 }, 301 },
299 } 302 }
OLDNEW
« no previous file with comments | « no previous file | tools/presubmit.py » ('j') | tools/testrunner/local/statusfile.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698