Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2080)

Unified Diff: chrome/installer/setup/installer_crash_reporter_client.cc

Issue 1475643004: Add crash keys for the installer covering simple InstallerState fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move command-line switch refactor to another patch for easier review Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/installer_crash_reporter_client.cc
diff --git a/chrome/installer/setup/installer_crash_reporter_client.cc b/chrome/installer/setup/installer_crash_reporter_client.cc
index a19f09507a201e4f400d2e8a9808a7d3ee92a55c..5bb0a17c91232f2846fd4c964399e87f7fe23596 100644
--- a/chrome/installer/setup/installer_crash_reporter_client.cc
+++ b/chrome/installer/setup/installer_crash_reporter_client.cc
@@ -13,6 +13,7 @@
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_version.h"
#include "chrome/common/env_vars.h"
+#include "chrome/installer/setup/installer_crash_keys.h"
#include "chrome/installer/util/google_update_settings.h"
#include "components/crash/core/common/crash_keys.h"
@@ -124,11 +125,9 @@ bool InstallerCrashReporterClient::GetCrashDumpLocation(
}
size_t InstallerCrashReporterClient::RegisterCrashKeys() {
- const base::debug::CrashKey kKeys[] = {
- { crash_keys::kClientId, crash_keys::kSmallSize },
- };
-
- return base::debug::InitCrashKeys(&kKeys[0], arraysize(kKeys),
+ std::vector<base::debug::CrashKey> keys;
+ installer::RegisterCrashKeys(keys);
+ return base::debug::InitCrashKeys(&keys.at(0), keys.size(),
grt (UTC plus 2) 2015/11/26 19:24:45 &keys.at(0) -> keys.data()
Joe Mason 2015/11/26 20:49:06 Done.
crash_keys::kChunkMaxLength);
}

Powered by Google App Engine
This is Rietveld 408576698