Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2842)

Unified Diff: chrome/installer/util/installer_state.h

Issue 1475643004: Add crash keys for the installer covering simple InstallerState fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix review comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/installer_state.h
diff --git a/chrome/installer/util/installer_state.h b/chrome/installer/util/installer_state.h
index bb24391975242439caa5b9779d5c9695526b0a43..d121eeff2c32bf8edd460ba25bb521bba8061ab5 100644
--- a/chrome/installer/util/installer_state.h
+++ b/chrome/installer/util/installer_state.h
@@ -107,11 +107,9 @@ class InstallerState {
Operation operation() const { return operation_; }
// A convenience method returning level() == SYSTEM_LEVEL.
- // TODO(grt): Eradicate the bool in favor of the enum.
bool system_install() const;
// A convenience method returning package_type() == MULTI_PACKAGE.
- // TODO(grt): Eradicate the bool in favor of the enum.
bool is_multi_install() const;
// The full path to the place where the operand resides.
« chrome/installer/setup/installer_crash_reporting.cc ('K') | « chrome/installer/setup/setup_main.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698