Add crash keys for the installer covering simple InstallerState fields.

chrome/installer/setup/installer_crash_reporting.h

Index: chrome/installer/setup/installer_crash_reporting.h
diff --git a/chrome/installer/setup/installer_crash_reporting.h b/chrome/installer/setup/installer_crash_reporting.h
new file mode 100644
index 0000000000000000000000000000000000000000..fcbc606eed8acb10e0e7d426132d30bab4728c2a
--- /dev/null
+++ b/chrome/installer/setup/installer_crash_reporting.h
@@ -0,0 +1,28 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_INSTALLER_SETUP_INSTALLER_CRASH_REPORTING_H_
+#define CHROME_INSTALLER_SETUP_INSTALLER_CRASH_REPORTING_H_
+
+#include <vector>
+
+#include "base/debug/crash_logging.h"
+
+namespace installer {
+
+class InstallerState;
+
+// Set up the crash reporting system for the installer.

[grt (UTC plus 2), 2015/11/26 21:37:18]

nit "Sets up..." as per
https://google.github.io/styleguide/cppguide.html#Function_Comments. here and
elsewhere.

[Joe Mason, 2015/11/26 22:28:54]

Done.

+void ConfigureCrashReporting(const InstallerState& installer_state);
+
+// Add the installer's default crash keys to |keys|.

[grt (UTC plus 2), 2015/11/26 21:37:18]

What does "default" mean? If this is to support other functions that would add
other keys to the collection, how do you expect this flexibility to be used? As
it is, I don't think the separation between this function and
InstallerCrashReporterClient::RegisterCrashKeys is needed. How about changing
the latter to:

size_t InstallerCrashReporterClient::RegisterCrashKeys() {
  return installer::RegisterCrashKeys();
}

and turning this into size_t RegisterCrashKeys()?

[Joe Mason, 2015/11/26 22:28:54]

Done.

+void GetCrashKeys(std::vector<base::debug::CrashKey>* keys);
+
+// Set all crash keys that are available after initializing |installer_state|

[grt (UTC plus 2), 2015/11/26 21:37:18]

I think you're describing an implementation detail here (not varying during
execution). The salient fact for the caller is that this sets crash keys for
which data is available during process startup. The fact that it takes an
InstallerState implies that the caller needs to make one of those first, so it
doesn't need to be documented.

[Joe Mason, 2015/11/26 22:28:54]

Since these keys don't vary, there's no need to call the function again, unlike
the upcoming SetAPValueCrashKey. That's a usage detail. Updated the doc string
to be more clear.

+// and do not vary during execution.
+void SetInitialCrashKeys(const InstallerState& installer_state);
+
+}  // namespace installer
+
+#endif  // CHROME_INSTALLER_SETUP_INSTALLER_CRASH_REPORTING_H_