Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1475633002: Correctly handlify Dictionary::CollectKeysTo. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correctly handlify Dictionary::CollectKeysTo. 'this' is a raw pointer and can be invalidated through GC, even though the rest of the code is correctly handlified. R=cbruni@chromium.org, jkummerow@chromium.org BUG=v8:4570 LOG=N Committed: https://crrev.com/912314be27451acf79106b35d3d09f6565c913cc Cr-Commit-Position: refs/heads/master@{#32208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M src/objects.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +24 lines, -18 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years ago (2015-11-24 13:19:13 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475633002/1
5 years ago (2015-11-24 13:19:46 UTC) #3
Jakob Kummerow
lgtm
5 years ago (2015-11-24 13:23:08 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-24 13:40:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475633002/1
5 years ago (2015-11-24 13:40:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 13:43:28 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-24 13:44:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/912314be27451acf79106b35d3d09f6565c913cc
Cr-Commit-Position: refs/heads/master@{#32208}

Powered by Google App Engine
This is Rietveld 408576698