Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 1475613002: [turbofan] Introduce proper CreateLiteralParameters. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@ArrayLiteral_LiteralIndexPush
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index ac72ee3576b66a3db2834a28866a8642521fe3d2..e10f7b96c128301bff28e2f9fdb5ea541308839d 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -1703,11 +1703,10 @@ void AstGraphBuilder::VisitObjectLiteral(ObjectLiteral* expr) {
// Create node to deep-copy the literal boilerplate.
Node* literals_array =
BuildLoadObjectField(closure, JSFunction::kLiteralsOffset);
- Node* literal_index = jsgraph()->Constant(expr->literal_index());
- Node* constants = jsgraph()->Constant(expr->constant_properties());
- const Operator* op =
- javascript()->CreateLiteralObject(expr->ComputeFlags(true));
- Node* literal = NewNode(op, literals_array, literal_index, constants);
+ const Operator* op = javascript()->CreateLiteralObject(
+ expr->constant_properties(), expr->ComputeFlags(true),
+ expr->literal_index());
+ Node* literal = NewNode(op, literals_array);
PrepareFrameState(literal, expr->CreateLiteralId(),
OutputFrameStateCombine::Push());
@@ -1909,11 +1908,10 @@ void AstGraphBuilder::VisitArrayLiteral(ArrayLiteral* expr) {
// Create node to deep-copy the literal boilerplate.
Node* literals_array =
BuildLoadObjectField(closure, JSFunction::kLiteralsOffset);
- Node* literal_index = jsgraph()->Constant(expr->literal_index());
- Node* constants = jsgraph()->Constant(expr->constant_elements());
- const Operator* op =
- javascript()->CreateLiteralArray(expr->ComputeFlags(true));
- Node* literal = NewNode(op, literals_array, literal_index, constants);
+ const Operator* op = javascript()->CreateLiteralArray(
+ expr->constant_elements(), expr->ComputeFlags(true),
+ expr->literal_index());
+ Node* literal = NewNode(op, literals_array);
PrepareFrameState(literal, expr->CreateLiteralId(),
OutputFrameStateCombine::Push());
« no previous file with comments | « no previous file | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698