Adding new user menu section to the SystemTrayMenu & refactoring of user access

chrome/browser/chromeos/login/user_manager_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_USER_MANAGER_IMPL_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_USER_MANAGER_IMPL_H_
 
 #include <map>
 #include <string>
 
@@ skipping 29 matching lines @@
       public content::NotificationObserver,
       public policy::DeviceLocalAccountPolicyService::Observer {
  public:
   virtual ~UserManagerImpl();
 
   // UserManager implementation:
   virtual void Shutdown() OVERRIDE;
   virtual UserImageManager* GetUserImageManager() OVERRIDE;
   virtual const UserList& GetUsers() const OVERRIDE;
   virtual const UserList& GetLoggedInUsers() const OVERRIDE;
+  virtual const UserList& GetLRULoggedInUsers() OVERRIDE;

[Nikita (slow), 2013/05/17 17:00:32]

Please add test for UserManager.

[Mr4D (OOO till 08-26), 2013/05/17 18:45:09]

As stated in my issue header: That will come with the next CL (which will add
the one missing UI element and the unit tests for UI and this).

   virtual void UserLoggedIn(const std::string& email,
                             const std::string& username_hash,
                             bool browser_restart) OVERRIDE;
   virtual void SwitchActiveUser(const std::string& email) OVERRIDE;
   virtual void SessionStarted() OVERRIDE;
   virtual void RemoveUser(const std::string& email,
                           RemoveUserDelegate* delegate) OVERRIDE;
   virtual void RemoveUserFromList(const std::string& email) OVERRIDE;
   virtual bool IsKnownUser(const std::string& email) const OVERRIDE;
   virtual const User* FindUser(const std::string& email) const OVERRIDE;
@@ skipping 184 matching lines @@
 
   // Lazily creates default user flow.
   UserFlow* GetDefaultUserFlow() const;
 
   // Update the global LoginState.
   void UpdateLoginState();
 
   // Gets the list of public accounts defined in device settings.
   void ReadPublicAccounts(base::ListValue* public_accounts);
 
+  // Insert |user| at the front of the LRU user list..
+  void SetLRUUser(User* user);
+
   // Interface to the signed settings store.
   CrosSettings* cros_settings_;
 
   // Interface to device-local account definitions and associated policy.
   policy::DeviceLocalAccountPolicyService* device_local_account_policy_service_;
 
   // True if users have been loaded from prefs already.
   bool users_loaded_;
 
   // List of all known users. User instances are owned by |this|. Regular users
   // are removed by |RemoveUserFromList|, public accounts by
   // |UpdateAndCleanUpPublicAccounts|.
   UserList users_;
 
   // List of all users that are logged in current session. These point to User
   // instances in |users_|. Only one of them could be marked as active.
   UserList logged_in_users_;
 
+  // A list of all users that are logged in the current session. In contrast to
+  // |logged_in_users|, the order of this list is least recently used so that
+  // the active user should always be the first one in the list.
+  UserList lru_logged_in_users_;
+
+  // The list which gets reported when the |lru_logged_in_users_| list is empty.
+  UserList temp_single_logged_in_users_;
+
   // The logged-in user that is currently active in current session.
   // NULL until a user has logged in, then points to one
   // of the User instances in |users_|, the |guest_user_| instance or an
   // ephemeral user instance.
   User* active_user_;
 
   // True if SessionStarted() has been called.
   bool session_started_;
 
   // Cached flag of whether currently logged-in user is owner or not.
@@ skipping 54 matching lines @@
 
   // Specific flows by user e-mail.
   FlowMap specific_flows_;
 
   DISALLOW_COPY_AND_ASSIGN(UserManagerImpl);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_USER_MANAGER_IMPL_H_