Adding new user menu section to the SystemTrayMenu & refactoring of user access

ash/system/user/tray_user.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/user/tray_user.h"
 
 #include <algorithm>
 #include <climits>
 #include <vector>
 
+#include "ash/session_state_delegate.h"
 #include "ash/shell.h"
 #include "ash/shell_delegate.h"
 #include "ash/system/tray/system_tray.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "ash/system/tray/system_tray_notifier.h"
 #include "ash/system/tray/tray_constants.h"
 #include "ash/system/tray/tray_item_view.h"
 #include "ash/system/tray/tray_popup_label_button.h"
 #include "ash/system/tray/tray_popup_label_button_border.h"
 #include "ash/system/tray/tray_utils.h"
@@ skipping 33 matching lines @@
 #include "ui/views/layout/box_layout.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/painter.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
 
 namespace {
 
 const int kUserDetailsVerticalPadding = 5;
 const int kUserCardVerticalPadding = 10;
+const int kInactiveUserCardVerticalPadding = 4;
 const int kProfileRoundedCornerRadius = 2;
 const int kUserIconSize = 27;
 const int kUserLabelToIconPadding = 5;
 
+// When a hover border is used, it is starting this many pixels before the icon
+// position.
+const int kTrayUserTileHoverBorderInset = 10;
+// The border color of the user button.

[Nikita (slow), 2013/05/17 17:00:32]

nit: Insert empty line.

[Mr4D (OOO till 08-26), 2013/05/17 18:45:09]

Done.

+const SkColor kBorderColor = 0xffdcdcdc;
+
 // The invisible word joiner character, used as a marker to indicate the start
 // and end of the user's display name in the public account user card's text.
 const char16 kDisplayNameMark[] = { 0x2060, 0 };
 
 const int kPublicAccountLogoutButtonBorderImagesNormal[] = {
     IDR_AURA_TRAY_POPUP_PUBLIC_ACCOUNT_LOGOUT_BUTTON_BORDER,
     IDR_AURA_TRAY_POPUP_LABEL_BUTTON_NORMAL_BACKGROUND,
     IDR_AURA_TRAY_POPUP_LABEL_BUTTON_NORMAL_BACKGROUND,
     IDR_AURA_TRAY_POPUP_PUBLIC_ACCOUNT_LOGOUT_BUTTON_BORDER,
     IDR_AURA_TRAY_POPUP_LABEL_BUTTON_NORMAL_BACKGROUND,
@@ skipping 19 matching lines @@
 
 namespace ash {
 namespace internal {
 
 namespace tray {
 
 // A custom image view with rounded edges.
 class RoundedImageView : public views::View {
  public:
   // Constructs a new rounded image view with rounded corners of radius
-  // |corner_radius|.
-  explicit RoundedImageView(int corner_radius);
+  // |corner_radius|. If |active_user| is set, the icon will be drawn in
+  // full colors - otherwise it will fade into the background.
+  RoundedImageView(int corner_radius, bool active_user);
   virtual ~RoundedImageView();
 
   // Set the image that should be displayed. The image contents is copied to the
   // receiver's image.
   void SetImage(const gfx::ImageSkia& img, const gfx::Size& size);
 
  private:
   // Overridden from views::View.
   virtual gfx::Size GetPreferredSize() OVERRIDE;
   virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;
 
   gfx::ImageSkia image_;
   gfx::ImageSkia resized_;
   gfx::Size image_size_;
   int corner_radius_;
 
+  // True if the given user is the active user and the icon should get
+  // painted as active.
+  bool active_user_;
+
   DISALLOW_COPY_AND_ASSIGN(RoundedImageView);
 };
 
-class ClickableAvatar : public views::CustomButton {
- public:
-  explicit ClickableAvatar(views::ButtonListener* listener);
-  virtual ~ClickableAvatar();
-
- private:
-  DISALLOW_COPY_AND_ASSIGN(ClickableAvatar);
-};
-
 // The user details shown in public account mode. This is essentially a label
 // but with custom painting code as the text is styled with multiple colors and
 // contains a link.
 class PublicAccountUserDetails : public views::View,
                                  public views::LinkListener {
  public:
   PublicAccountUserDetails(SystemTrayItem* owner, int used_width);
   virtual ~PublicAccountUserDetails();
 
  private:
@@ skipping 11 matching lines @@
   void CalculatePreferredSize(SystemTrayItem* owner, int used_width);
 
   base::string16 text_;
   views::Link* learn_more_;
   gfx::Size preferred_size_;
   ScopedVector<gfx::RenderText> lines_;
 
   DISALLOW_COPY_AND_ASSIGN(PublicAccountUserDetails);
 };
 
+// The button which holds the user card in case of multi profile.
+class UserCard : public views::CustomButton {
+ public:
+  UserCard(views::ButtonListener* listener, bool active_user);
+  virtual ~UserCard();
+
+  // Overridden from views::View
+  virtual void OnMouseEntered(const ui::MouseEvent& event) OVERRIDE;
+  virtual void OnMouseExited(const ui::MouseEvent& event) OVERRIDE;
+
+ private:
+  void ShowActive(bool active);

[Nikita (slow), 2013/05/17 17:00:32]

nit: Comment?

[Mr4D (OOO till 08-26), 2013/05/17 18:45:09]

Done.

+
+  // True if this is the active user.
+  bool is_active_user_;
+  DISALLOW_COPY_AND_ASSIGN(UserCard);
+};
+
 class UserView : public views::View,
                  public views::ButtonListener {
  public:
-  explicit UserView(SystemTrayItem* owner, ash::user::LoginStatus login);
+  UserView(SystemTrayItem* owner,
+           ash::user::LoginStatus login,
+           MultiProfileIndex index);
   virtual ~UserView();
 
  private:
   // Overridden from views::View.
   virtual gfx::Size GetPreferredSize() OVERRIDE;
   virtual int GetHeightForWidth(int width) OVERRIDE;
   virtual void Layout() OVERRIDE;
 
   // Overridden from views::ButtonListener.
   virtual void ButtonPressed(views::Button* sender,
                              const ui::Event& event) OVERRIDE;
 
   void AddLogoutButton(ash::user::LoginStatus login);
   void AddUserCard(SystemTrayItem* owner, ash::user::LoginStatus login);
 
+  MultiProfileIndex multiprofile_index_;
   views::View* user_card_;
   views::View* logout_button_;
-  ClickableAvatar* profile_picture_;
 
   DISALLOW_COPY_AND_ASSIGN(UserView);
 };
 
-RoundedImageView::RoundedImageView(int corner_radius)
-    : corner_radius_(corner_radius) {}
+RoundedImageView::RoundedImageView(int corner_radius, bool active_user)
+    : corner_radius_(corner_radius),
+      active_user_(active_user) {}
 
 RoundedImageView::~RoundedImageView() {}
 
 void RoundedImageView::SetImage(const gfx::ImageSkia& img,
                                 const gfx::Size& size) {
   image_ = img;
   image_size_ = size;
 
   // Try to get the best image quality for the avatar.
   resized_ = gfx::ImageSkiaOperations::CreateResizedImage(image_,
@@ skipping 12 matching lines @@
 void RoundedImageView::OnPaint(gfx::Canvas* canvas) {
   View::OnPaint(canvas);
   gfx::Rect image_bounds(size());
   image_bounds.ClampToCenteredSize(GetPreferredSize());
   image_bounds.Inset(GetInsets());
   const SkScalar kRadius = SkIntToScalar(corner_radius_);
   SkPath path;
   path.addRoundRect(gfx::RectToSkRect(image_bounds), kRadius, kRadius);
   SkPaint paint;
   paint.setAntiAlias(true);
-  paint.setXfermodeMode(SkXfermode::kSrcOver_Mode);
+  paint.setXfermodeMode(active_user_ ? SkXfermode::kSrcOver_Mode :
+                                       SkXfermode::kLuminosity_Mode);
   canvas->DrawImageInPath(resized_, image_bounds.x(), image_bounds.y(),
                           path, paint);
 }
 
-ClickableAvatar::ClickableAvatar(views::ButtonListener* listener)
-    : views::CustomButton(listener) {
-  SetLayoutManager(new views::FillLayout());
-  RoundedImageView* user_picture =
-      new RoundedImageView(kProfileRoundedCornerRadius);
-  user_picture->SetImage(
-      ash::Shell::GetInstance()->system_tray_delegate()->GetUserImage(),
-      gfx::Size(kUserIconSize, kUserIconSize));
-  AddChildView(user_picture);
-}
-
-ClickableAvatar::~ClickableAvatar() {}
-
 PublicAccountUserDetails::PublicAccountUserDetails(SystemTrayItem* owner,
                                                    int used_width)
     : learn_more_(NULL) {
   const int inner_padding =
       kTrayPopupPaddingHorizontal - kTrayPopupPaddingBetweenItems;
   const bool rtl = base::i18n::IsRTL();
   set_border(views::Border::CreateEmptyBorder(
       kUserDetailsVerticalPadding, rtl ? 0 : inner_padding,
       kUserDetailsVerticalPadding, rtl ? inner_padding : 0));
 
-  ash::SystemTrayDelegate* delegate =
-      ash::Shell::GetInstance()->system_tray_delegate();
   // Retrieve the user's display name and wrap it with markers.
-  base::string16 display_name = delegate->GetUserDisplayName();
+  // Note that since this is a public account it always has to be the primary
+  // user.
+  base::string16 display_name =
+      ash::Shell::GetInstance()->session_state_delegate()->GetUserDisplayName(
+          0);

[Nikita (slow), 2013/05/17 17:00:32]

nit: Please move method name to this line.

[Mr4D (OOO till 08-26), 2013/05/17 18:45:09]

This was never asked for before. Done.

   RemoveChars(display_name, kDisplayNameMark, &display_name);
   display_name = kDisplayNameMark[0] + display_name + kDisplayNameMark[0];
   // Retrieve the domain managing the device and wrap it with markers.
-  base::string16 domain = UTF8ToUTF16(delegate->GetEnterpriseDomain());
+  base::string16 domain = UTF8ToUTF16(
+      ash::Shell::GetInstance()->system_tray_delegate()->GetEnterpriseDomain());
   RemoveChars(domain, kDisplayNameMark, &domain);
   base::i18n::WrapStringWithLTRFormatting(&domain);
   // Retrieve the label text, inserting the display name and domain.
   text_ = l10n_util::GetStringFUTF16(IDS_ASH_STATUS_TRAY_PUBLIC_LABEL,
                                      display_name, domain);
 
   learn_more_ = new views::Link(l10n_util::GetStringUTF16(IDS_ASH_LEARN_MORE));
   learn_more_->SetUnderline(false);
   learn_more_->set_listener(this);
   AddChildView(learn_more_);
 
   CalculatePreferredSize(owner, used_width);
 }
 
 PublicAccountUserDetails::~PublicAccountUserDetails() {}
 
 void PublicAccountUserDetails::Layout() {
   lines_.clear();
   const gfx::Rect contents_area = GetContentsBounds();
   if (contents_area.IsEmpty())
-     return;
+    return;
 
   // Word-wrap the label text.
   const gfx::Font font;
   std::vector<base::string16> lines;
   ui::ElideRectangleText(text_, font, contents_area.width(),
                          contents_area.height(), ui::ELIDE_LONG_WORDS, &lines);
   // Loop through the lines, creating a renderer for each.
   gfx::Point position = contents_area.origin();
   ui::Range display_name(ui::Range::InvalidRange());
   for (std::vector<base::string16>::const_iterator it = lines.begin();
@@ skipping 115 matching lines @@
   const int line_height = font.GetHeight();
   const int link_extra_height = std::max(
       link_size.height() - learn_more_->GetInsets().top() - line_height, 0);
   preferred_size_ = gfx::Size(
       min_width + insets.width(),
       line_count * line_height + link_extra_height + insets.height());
 
   bubble_view->SetWidth(preferred_size_.width() + used_width);
 }
 
-UserView::UserView(SystemTrayItem* owner, ash::user::LoginStatus login)
-    : user_card_(NULL),
-      logout_button_(NULL),
-      profile_picture_(NULL) {
+UserCard::UserCard(views::ButtonListener* listener, bool active_user)
+    : CustomButton(listener),
+      is_active_user_(active_user) {
+  if (is_active_user_) {
+    set_background(
+        views::Background::CreateSolidBackground(kBackgroundColor));
+    ShowActive(false);
+  }
+}
+
+UserCard::~UserCard() {}
+
+void UserCard::OnMouseEntered(const ui::MouseEvent& event) OVERRIDE {
+  if (is_active_user_) {
+    background()->SetNativeControlColor(kHoverBackgroundColor);
+    ShowActive(true);
+    SchedulePaint();
+  }
+}
+
+void UserCard::OnMouseExited(const ui::MouseEvent& event) OVERRIDE {
+  if (is_active_user_) {
+    background()->SetNativeControlColor(kBackgroundColor);
+    ShowActive(false);
+    SchedulePaint();
+  }
+}
+
+void UserCard::ShowActive(bool active) {
+  int width = active ? 1 : 0;
+  set_border(views::Border::CreateSolidSidedBorder(width, width, width, 1,
+                                                   kBorderColor));
+}
+
+UserView::UserView(SystemTrayItem* owner,
+                   ash::user::LoginStatus login,
+                   MultiProfileIndex index)
+    : multiprofile_index_(index),
+      user_card_(NULL),
+      logout_button_(NULL) {
   CHECK_NE(ash::user::LOGGED_IN_NONE, login);
-  set_background(views::Background::CreateSolidBackground(
-      login == ash::user::LOGGED_IN_PUBLIC ? kPublicAccountBackgroundColor :
-                                             kBackgroundColor));
+  if (!index) {
+    // Only the logged in user will have a background. All other users will have
+    // have none to allow the TrayPopupContainer to highlight the menu line.

[Nikita (slow), 2013/05/17 17:00:32]

nit: drop second "have"

[Mr4D (OOO till 08-26), 2013/05/17 18:45:09]

Done.

+    set_background(views::Background::CreateSolidBackground(
+        login == ash::user::LOGGED_IN_PUBLIC ? kPublicAccountBackgroundColor :
+                                               kBackgroundColor));
+  }
   SetLayoutManager(new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0,
                                         kTrayPopupPaddingBetweenItems));
   // The logout button must be added before the user card so that the user card
   // can correctly calculate the remaining available width.
-  AddLogoutButton(login);
+  // Note that only the current multiprofile user gets a button.
+  AddLogoutButton(!multiprofile_index_ ? login : ash::user::LOGGED_IN_LOCKED);
   AddUserCard(owner, login);
 }
 
 UserView::~UserView() {}
 
 gfx::Size UserView::GetPreferredSize() {
   gfx::Size size = views::View::GetPreferredSize();
   if (!user_card_) {
-    // Make sure the default user view item is at least as tall as the other
-    // items.
+    // The default user view item should be at least as tall as the other items.
     size.set_height(std::max(size.height(),
                              kTrayPopupItemHeight + GetInsets().height()));
   }
   return size;
 }
 
 int UserView::GetHeightForWidth(int width) {
   return GetPreferredSize().height();
 }
 
 void UserView::Layout() {
   gfx::Rect contents_area(GetContentsBounds());
   if (user_card_ && logout_button_) {
     // Give the logout button the space it requests.
     gfx::Rect logout_area = contents_area;
     logout_area.ClampToCenteredSize(logout_button_->GetPreferredSize());
     logout_area.set_x(contents_area.right() - logout_area.width());
-    logout_button_->SetBoundsRect(logout_area);
 
     // Give the remaining space to the user card.
     gfx::Rect user_card_area = contents_area;
-    int remaining_width = contents_area.width() -
-        (logout_area.width() + kTrayPopupPaddingBetweenItems);
-    user_card_area.set_width(std::max(0, remaining_width));
+    int remaining_width = contents_area.width() - logout_area.width();
+    if (ash::Shell::GetInstance()->delegate()->IsMultiProfilesEnabled()) {
+      // In multiprofile case |user_card_| and |logout_button_| have to have the
+      // same height.
+      int y = std::min(user_card_area.y(), logout_area.y());
+      int height = std::max(user_card_area.height(), logout_area.height());
+      logout_area.set_y(y);
+      logout_area.set_height(height);
+      user_card_area.set_y(y);
+      user_card_area.set_height(height);
+      // In multiprofile mode we have also to increase the size of the card by

[Nikita (slow), 2013/05/17 17:00:32]

nit: Please insert empty line before comment.

[Mr4D (OOO till 08-26), 2013/05/17 18:45:09]

Never heard that before - done.

+      // the size of the border to make it overlap with the logout button.
+      user_card_area.set_width(std::max(0, remaining_width + 1));
+      // To make the logout button symmetrical with the user card we also make

[Nikita (slow), 2013/05/17 17:00:32]

nit: Empty line before comment.

[Mr4D (OOO till 08-26), 2013/05/17 18:45:09]

Ditto

+      // the button longer by the same size the hover area in front of the icon
+      // got inset.
+      logout_area.set_width(logout_area.width() +
+                            kTrayUserTileHoverBorderInset);
+    } else {
+      // In all other modes we have to make sure that there is enough spacing
+      // between the two.
+      remaining_width -= kTrayPopupPaddingBetweenItems;
+    }
     user_card_->SetBoundsRect(user_card_area);
+    logout_button_->SetBoundsRect(logout_area);
   } else if (user_card_) {
     user_card_->SetBoundsRect(contents_area);
   } else if (logout_button_) {
     logout_button_->SetBoundsRect(contents_area);
   }
 }
 
 void UserView::ButtonPressed(views::Button* sender, const ui::Event& event) {
   if (sender == logout_button_) {
     ash::Shell::GetInstance()->system_tray_delegate()->SignOut();
-  } else if (sender == profile_picture_) {
-    if (ash::Shell::GetInstance()->delegate()->IsMultiProfilesEnabled())
-      ash::Shell::GetInstance()->system_tray_delegate()->ShowUserLogin();
-    else
-      ash::Shell::GetInstance()->system_tray_delegate()->ChangeProfilePicture();
+  } else if (sender == user_card_ &&
+             ash::Shell::GetInstance()->delegate()->IsMultiProfilesEnabled()) {
+    if (!multiprofile_index_) {
+      // TODO(skuhne): Need to add the images & adding logic here.
+      // TODO(skuhne): Make sure that we do not offer an add when this mode is
+      // active.
+      // TODO(skuhne): Use IDS_ASH_STATUS_TRAY_SIGN_IN_ANOTHER_ACCOUNT as
+      // string.
+      const SessionStateDelegate* session_state_delegate =
+          ash::Shell::GetInstance()->session_state_delegate();
+      if (session_state_delegate->NumberOfLoggedInUsers() >=
+              session_state_delegate->GetMaximumNumberOfLoggedInUsers()) {
+        // TODO(skuhne): Use IDS_ASH_STATUS_TRAY_CAPTION_CANNOT_ADD_USER and
+        // IDS_ASH_STATUS_TRAY_MESSAGE_CANNOT_ADD_USER when showing the error
+        // message that no more users can be added.
+      } else {
+        ash::Shell::GetInstance()->system_tray_delegate()->ShowUserLogin();
+      }
+    } else {
+      ash::SessionStateDelegate* delegate =
+          ash::Shell::GetInstance()->session_state_delegate();
+      delegate->SwitchActiveUser(delegate->GetUserEmail(multiprofile_index_));
+    }
   } else {
     NOTREACHED();
   }
 }
 
 void UserView::AddLogoutButton(ash::user::LoginStatus login) {
   // A user should not be able to modify logged-in state when screen is
   // locked.
   if (login == ash::user::LOGGED_IN_LOCKED)
     return;
@@ skipping 13 matching lines @@
     border->SetPainter(false, views::Button::STATE_HOVERED,
                        views::Painter::CreateImageGridPainter(
                            kPublicAccountLogoutButtonBorderImagesHovered));
     border->SetPainter(false, views::Button::STATE_PRESSED,
                        views::Painter::CreateImageGridPainter(
                            kPublicAccountLogoutButtonBorderImagesHovered));
   }
   AddChildView(logout_button_);
 }
 
 void UserView::AddUserCard(SystemTrayItem* owner,

[Nikita (slow), 2013/05/17 17:00:32]

Seems that this method should be split into smaller parts - it is 100 lines.

[Mr4D (OOO till 08-26), 2013/05/17 18:45:09]

I was shorten it. It is still a bit big, but much better.

                            ash::user::LoginStatus login) {
   if (login == ash::user::LOGGED_IN_GUEST)
     return;
 
-  set_border(views::Border::CreateEmptyBorder(0, kTrayPopupPaddingHorizontal,
-                                              0, kTrayPopupPaddingHorizontal));
+  // Add padding around the panel.
+  set_border(views::Border::CreateEmptyBorder(
+      kUserCardVerticalPadding, kTrayPopupPaddingHorizontal,
+      kUserCardVerticalPadding, kTrayPopupPaddingHorizontal));
 
-  user_card_ = new views::View();
+  if (ash::Shell::GetInstance()->delegate()->IsMultiProfilesEnabled() &&
+      login != ash::user::LOGGED_IN_RETAIL_MODE)
+    user_card_ = new UserCard(this, multiprofile_index_ == 0);

[Nikita (slow), 2013/05/17 17:00:32]

nit: Add {}

[Mr4D (OOO till 08-26), 2013/05/17 18:45:09]

Well... I always thought that this was okay since there isa single line in the
if and the else case. Done.

[Nikita (slow), 2013/05/17 19:15:47]

Seems more readable when condition is on multiple lines.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Conditionals
"In general, curly braces are not required for single-line statements, but they
are allowed if you like them; conditional or loop statements with complex
conditions or statements may be more readable with curly braces."

[Mr4D (OOO till 08-26), 2013/05/17 20:04:43]

Well - so it is formulated in a way that both is okay. Either way - done. 

+  else
+    user_card_ = new views::View();
+
   user_card_->SetLayoutManager(new views::BoxLayout(
-      views::BoxLayout::kHorizontal, 0, kUserCardVerticalPadding,
-      kTrayPopupPaddingBetweenItems));
+      views::BoxLayout::kHorizontal, 0, 0 , kTrayPopupPaddingBetweenItems));
   AddChildViewAt(user_card_, 0);
 
   if (login == ash::user::LOGGED_IN_RETAIL_MODE) {
     views::Label* details = new views::Label;
     ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
     details->SetText(
         bundle.GetLocalizedString(IDS_ASH_STATUS_TRAY_KIOSK_LABEL));
     details->set_border(views::Border::CreateEmptyBorder(0, 4, 0, 1));
     details->SetHorizontalAlignment(gfx::ALIGN_LEFT);
     user_card_->AddChildView(details);
     return;
   }
-  profile_picture_ = new ClickableAvatar(this);
-  user_card_->AddChildView(profile_picture_);
+
+  // The entire user card should trigger hover (the inner items get disabled).
+  user_card_->SetEnabled(true);
+
+  RoundedImageView* icon = new RoundedImageView(kProfileRoundedCornerRadius,
+                                                multiprofile_index_ == 0);
+  icon->SetEnabled(false);
+  icon->SetImage(
+      ash::Shell::GetInstance()->session_state_delegate()->GetUserImage(
+          multiprofile_index_),

[Nikita (slow), 2013/05/17 17:00:32]

nit: Please move method name to this line.

[Mr4D (OOO till 08-26), 2013/05/17 18:45:09]

Done.

+      gfx::Size(kUserIconSize, kUserIconSize));
+  user_card_->AddChildView(icon);
 
   if (login == ash::user::LOGGED_IN_PUBLIC) {
     user_card_->AddChildView(new PublicAccountUserDetails(
         owner, GetPreferredSize().width() + kTrayPopupPaddingBetweenItems));
     return;
   }
 
-  ash::SystemTrayDelegate* delegate =
-      ash::Shell::GetInstance()->system_tray_delegate();
+  // To allow the border to start before the icon, reduce the size before and
+  // add an inset to the icon to get the spacing.
+  if (multiprofile_index_ == 0 &&
+      ash::Shell::GetInstance()->delegate()->IsMultiProfilesEnabled()) {
+    icon->set_border(views::Border::CreateEmptyBorder(
+        0, kTrayUserTileHoverBorderInset, 0, 0));
+    set_border(views::Border::CreateEmptyBorder(
+        kUserCardVerticalPadding,
+        kTrayPopupPaddingHorizontal - kTrayUserTileHoverBorderInset,
+        kUserCardVerticalPadding,
+        kTrayPopupPaddingHorizontal));
+  }
+  ash::SessionStateDelegate* delegate =
+      ash::Shell::GetInstance()->session_state_delegate();
   views::View* details = new views::View;
+  details->SetEnabled(false);
   details->SetLayoutManager(new views::BoxLayout(
       views::BoxLayout::kVertical, 0, kUserDetailsVerticalPadding, 0));
-  views::Label* username = new views::Label(delegate->GetUserDisplayName());
-  username->SetHorizontalAlignment(gfx::ALIGN_LEFT);
-  details->AddChildView(username);
-
+  views::Label* username = NULL;
+  if (!multiprofile_index_) {
+    username =
+        new views::Label(delegate->GetUserDisplayName(multiprofile_index_));
+    username->SetEnabled(false);
+    username->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+    details->AddChildView(username);
+  }
   ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
 
   views::Label* additional = new views::Label();
-
+  additional->SetEnabled(false);
   additional->SetText(login == ash::user::LOGGED_IN_LOCALLY_MANAGED ?
       bundle.GetLocalizedString(IDS_ASH_STATUS_TRAY_LOCALLY_MANAGED_LABEL) :
-      UTF8ToUTF16(delegate->GetUserEmail()));
+      UTF8ToUTF16(delegate->GetUserEmail(multiprofile_index_)));
 
-  additional->SetFont(bundle.GetFont(ui::ResourceBundle::SmallFont));
   additional->SetHorizontalAlignment(gfx::ALIGN_LEFT);
-  additional->SetEnabled(false);
   details->AddChildView(additional);
+  // Adjust text properties dependent on if it is an active or inactive user.
+  if (multiprofile_index_) {
+    // Fade the text of non active users to 50%.
+    SkColor text_color = additional->enabled_color();
+    text_color = SkColorSetA(text_color, SkColorGetA(text_color) / 2);
+    additional->SetDisabledColor(text_color);
+    if (username)
+      username->SetDisabledColor(text_color);
+  }
+
+  // Use a small font for email address if username is given.
+  if (username)
+    additional->SetFont(bundle.GetFont(ui::ResourceBundle::SmallFont));
+
   user_card_->AddChildView(details);
 }
 
 }  // namespace tray
 
-TrayUser::TrayUser(SystemTray* system_tray)
+TrayUser::TrayUser(SystemTray* system_tray, MultiProfileIndex index)
     : SystemTrayItem(system_tray),
+      multiprofile_index_(index),
       user_(NULL),
       layout_view_(NULL),
       avatar_(NULL),
       label_(NULL) {
   Shell::GetInstance()->system_tray_notifier()->AddUserObserver(this);
 }
 
 TrayUser::~TrayUser() {
   Shell::GetInstance()->system_tray_notifier()->RemoveUserObserver(this);
 }
 
 views::View* TrayUser::CreateTrayView(user::LoginStatus status) {
   CHECK(layout_view_ == NULL);
+  // Only the current user gets an icon. All other users will only be
+  // represented in the tray menu.
+  if (multiprofile_index_)
+    return NULL;
+
   layout_view_ = new views::View();
   layout_view_->SetLayoutManager(
       new views::BoxLayout(views::BoxLayout::kHorizontal,
                            0, 0, kUserLabelToIconPadding));
   UpdateAfterLoginStatusChange(status);
   return layout_view_;
 }
 
 views::View* TrayUser::CreateDefaultView(user::LoginStatus status) {
   if (status == user::LOGGED_IN_NONE)
     return NULL;
 
   CHECK(user_ == NULL);
-  user_ = new tray::UserView(this, status);
+
+  const SessionStateDelegate* session_state_delegate =
+      ash::Shell::GetInstance()->session_state_delegate();
+  int logged_in_users = session_state_delegate->NumberOfLoggedInUsers();
+
+  // If there are multiple users logged in, the users will be separated from the
+  // rest of the menu by a separator.
+  if (multiprofile_index_ ==
+          session_state_delegate->GetMaximumNumberOfLoggedInUsers() &&
+      logged_in_users > 1)
+    return new views::View();

[Nikita (slow), 2013/05/17 17:00:32]

nit: Add {}

[Mr4D (OOO till 08-26), 2013/05/17 18:45:09]

Ditto. Done.

+
+  // Do not show more UserView's then there are logged in users.
+  if (multiprofile_index_ >= logged_in_users)
+    return NULL;;
+
+  user_ = new tray::UserView(this, status, multiprofile_index_);
   return user_;
 }
 
 views::View* TrayUser::CreateDetailedView(user::LoginStatus status) {
   return NULL;
 }
 
 void TrayUser::DestroyTrayView() {
   layout_view_ = NULL;
   avatar_ = NULL;
   label_ = NULL;
 }
 
 void TrayUser::DestroyDefaultView() {
   user_ = NULL;
 }
 
 void TrayUser::DestroyDetailedView() {
 }
 
 void TrayUser::UpdateAfterLoginStatusChange(user::LoginStatus status) {
-  CHECK(layout_view_);
+  // Only the active user is represented in the tray.
+  if (!layout_view_)
+    return;
   bool need_label = false;
   bool need_avatar = false;
   switch (status) {
     case user::LOGGED_IN_LOCKED:
     case user::LOGGED_IN_USER:
     case user::LOGGED_IN_OWNER:
     case user::LOGGED_IN_PUBLIC:
       need_avatar = true;
       break;
     case user::LOGGED_IN_LOCALLY_MANAGED:
@@ skipping 13 matching lines @@
       (need_label != (label_ != NULL))) {
     layout_view_->RemoveAllChildViews(true);
     if (need_label) {
       label_ = new views::Label;
       SetupLabelForTray(label_);
       layout_view_->AddChildView(label_);
     } else {
       label_ = NULL;
     }
     if (need_avatar) {
-      avatar_ = new tray::RoundedImageView(kProfileRoundedCornerRadius);
+      avatar_ = new tray::RoundedImageView(kProfileRoundedCornerRadius, true);
       layout_view_->AddChildView(avatar_);
     } else {
       avatar_ = NULL;
     }
   }
 
   ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
   if (status == user::LOGGED_IN_LOCALLY_MANAGED) {
     label_->SetText(
         bundle.GetLocalizedString(IDS_ASH_STATUS_TRAY_LOCALLY_MANAGED_LABEL));
   } else if (status == user::LOGGED_IN_GUEST) {
     label_->SetText(bundle.GetLocalizedString(IDS_ASH_STATUS_TRAY_GUEST_LABEL));
   }
 
   if (avatar_) {
     avatar_->SetImage(
-        ash::Shell::GetInstance()->system_tray_delegate()->GetUserImage(),
+        ash::Shell::GetInstance()->session_state_delegate()->GetUserImage(
+            multiprofile_index_),
         gfx::Size(kUserIconSize, kUserIconSize));
   }
 }
 
 void TrayUser::UpdateAfterShelfAlignmentChange(ShelfAlignment alignment) {
-  CHECK(layout_view_);
+  // Inactive users won't have a layout.
+  if (!layout_view_)
+    return;
   if (alignment == SHELF_ALIGNMENT_BOTTOM ||
       alignment == SHELF_ALIGNMENT_TOP) {
     if (avatar_) {
       avatar_->set_border(views::Border::CreateEmptyBorder(
           0, kTrayImageItemHorizontalPaddingBottomAlignment + 2,
           0, kTrayImageItemHorizontalPaddingBottomAlignment));
 
     }
     if (label_) {
       label_->set_border(views::Border::CreateEmptyBorder(
@@ skipping 16 matching lines @@
     layout_view_->SetLayoutManager(
         new views::BoxLayout(views::BoxLayout::kVertical,
                              0, 0, kUserLabelToIconPadding));
   }
 }
 
 void TrayUser::OnUserUpdate() {
   // Check for null to avoid crbug.com/150944.
   if (avatar_) {
     avatar_->SetImage(
-        ash::Shell::GetInstance()->system_tray_delegate()->GetUserImage(),
+        ash::Shell::GetInstance()->session_state_delegate()->GetUserImage(
+            multiprofile_index_),
         gfx::Size(kUserIconSize, kUserIconSize));
   }
 }
 
 }  // namespace internal
 }  // namespace ash