components/arc/common/arc_message_param_traits.h - Issue 1475583002: Add IPC messages for ARC notification

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/arc/common/arc_message_param_traits.h

Issue 1475583002: Add IPC messages for ARC notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed the comments and splitted the patch Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/arc/common/arc_instance_messages.h ('k') | components/arc/common/arc_message_param_traits.cc » ('j') | components/arc/common/arc_notification_types.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.
	hidehiko 2015/11/26 03:39:41 IPC_STRUCT_TRAITS_{BEGIN,END,MEMBER} macros are yo IPC_STRUCT_TRAITS_{BEGIN,END,MEMBER} macros are your friends. https://code.google.com/p/chromium/codesearch#chromium/src/ipc/param_traits_m... Also, you may be interested in IPC_ENUM_TRAITS* family. You can use https://code.google.com/p/chromium/codesearch#chromium/src/components/nacl/co... as a reference, I think. yoshiki 2015/11/26 10:36:21 Thank you for letting me know! I updated the code Show quoted text On 2015/11/26 03:39:41, hidehiko wrote: > IPC_STRUCT_TRAITS_{BEGIN,END,MEMBER} macros are your friends. > https://code.google.com/p/chromium/codesearch#chromium/src/ipc/param_traits_m... > > Also, you may be interested in IPC_ENUM_TRAITS* family. > > You can use > https://code.google.com/p/chromium/codesearch#chromium/src/components/nacl/co... > as a reference, I think. Thank you for letting me know! I updated the code with macros.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_ARC_COMMON_ARC_HOST_MESSAGE_PARAM_TRAITS_H_

	6 #define COMPONENTS_ARC_COMMON_ARC_HOST_MESSAGE_PARAM_TRAITS_H_

	7

	8 #include "ipc/ipc_export.h"

	9 #include "ipc/ipc_message_utils.h"

	10

	11 // Using relative paths since this file is shared between chromium and android.

	12 #include "arc_notification_types.h"

	13

	14 namespace IPC {

	15

	16 template <>

	17 struct IPC_EXPORT ParamTraits<arc::ArcNotificationData> {

	18 typedef arc::ArcNotificationData param_type;

	19 static void Write(Message* m, const param_type& p);

	20 static bool Read(const Message* m, base::PickleIterator* iter, param_type* p);

	21 static void Log(const param_type& p, std::string* l);

	22 };

	23

	24 } // namespace IPC

	25

	26 #endif // COMPONENTS_ARC_COMMON_ARC_HOST_MESSAGE_PARAM_TRAITS_H_

OLD	NEW