Add IPC messages for ARC notification

components/arc/common/arc_host_messages.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Messages sent from the ARC instance to the host.
 // Multiply-included message file, hence no include guard.
 
 #include "ipc/ipc_message_macros.h"
 
-#include "components/arc/common/arc_message_types.h"
+// Using relative paths since this file is shared between chromium and android.
+#include "arc_message_types.h"
+#include "arc_notification_types.h"
 
 #define IPC_MESSAGE_START ArcInstanceHostMsgStart
 
 IPC_ENUM_TRAITS_MAX_VALUE(arc::InstanceBootPhase, arc::InstanceBootPhase::LAST)
 
 IPC_MESSAGE_CONTROL1(ArcInstanceHostMsg_InstanceBootPhase,
                      arc::InstanceBootPhase)
+
+// Enum for notification type.
+IPC_ENUM_TRAITS_MAX_VALUE(arc::ArcNotificationType,
+                          arc::ArcNotificationType::NOTIFICATION_TYPE_LAST)
+
+// Struct for notification data.
+IPC_STRUCT_TRAITS_BEGIN(arc::ArcNotificationData)

[khmel1, 2015/12/01 06:44:51]

In my CL I put similar code into arc_messages_traits.h, however not sure what is
standard in Chromium?

[yoshiki, 2015/12/02 02:38:24]

I think this can be in this file, since there is only one struct trait and this
is only used by the host messages. Please feel free to move this when you add
more traits.

+  IPC_STRUCT_TRAITS_MEMBER(key)
+  IPC_STRUCT_TRAITS_MEMBER(type)
+  IPC_STRUCT_TRAITS_MEMBER(message)
+  IPC_STRUCT_TRAITS_MEMBER(title)
+  IPC_STRUCT_TRAITS_MEMBER(icon_mimetype)
+  IPC_STRUCT_TRAITS_MEMBER(icon_data)
+  IPC_STRUCT_TRAITS_MEMBER(priority)
+  IPC_STRUCT_TRAITS_MEMBER(timestamp)
+  IPC_STRUCT_TRAITS_MEMBER(progress_current)
+  IPC_STRUCT_TRAITS_MEMBER(progress_max)
+IPC_STRUCT_TRAITS_END()
+
+// Notifies that a notification is posted (created or updated) on Android with

[hidehiko, 2015/12/01 06:35:43]

nit: Similar to the method name, it'd be probably easier to understand if you
can avoid using a word "notify" under two context. Maybe

"Tells the Chrome that a notification is posted (created or updated) on Android.
|notification_data| is the contents and metadata of the notification."

etc.?

[yoshiki, 2015/12/02 02:38:24]

Done.

+// the updated notification data.
+// |notification_data| is the data of notification (id, texts, icon and ...).
+IPC_MESSAGE_CONTROL1(ArcInstanceHostMsg_NotificationPosted,
+                     arc::ArcNotificationData /* notification_data */);
+
+// Notifies that a notification is removed on Android.
+// |key| is the identifier of notification.

[hidehiko, 2015/12/01 06:35:43]

nit: "the notification"

[yoshiki, 2015/12/02 02:38:24]

Done.

+IPC_MESSAGE_CONTROL1(ArcInstanceHostMsg_NotificationRemoved,
+                     std::string /* key */);