components/arc/common/arc_message_traits.h - Issue 1475563002: arc-bridge: Implement IPC message for app launcher

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/arc/common/arc_message_traits.h

Issue 1475563002: arc-bridge: Implement IPC message for app launcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add arc::ScaleFactor enum Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/arc/arc_bridge_service.h ('K') | « components/arc/common/arc_message_generator.h ('k') | components/arc/common/arc_message_types.h » ('j') | components/arc/common/arc_message_types.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/arc/common/arc_message_types.h"

	6 #include "ipc/ipc_message_macros.h"

	7 #include "ipc/ipc_message_utils.h"

	8

	9 IPC_ENUM_TRAITS_MIN_MAX_VALUE(arc::ScaleFactor,

	10 arc::ScaleFactor::SCALE_FACTOR_100P,
	yoshiki 2015/12/03 02:24:32 SCALE_FACTOR_NONE is never passed, right? SCALE_FA SCALE_FACTOR_NONE is never passed, right? SCALE_FACTOR_NONE is smaller than SCALE_FACTOR_100P. khmel1 2015/12/03 03:53:27 Right, SCALE_FACTOR_NONE is invalid value for this Show quoted text On 2015/12/03 02:24:32, yoshiki wrote: > SCALE_FACTOR_NONE is never passed, right? SCALE_FACTOR_NONE is smaller than > SCALE_FACTOR_100P. Right, SCALE_FACTOR_NONE is invalid value for this IPC and it is yes, smaller than 100P.
	11 arc::ScaleFactor::NUM_SCALE_FACTORS);
	yoshiki 2015/12/03 02:24:32 This is the max value, so you may specify "NUM_SCA This is the max value, so you may specify "NUM_SCALE_FACTORS - 1"? khmel1 2015/12/03 03:53:27 Yes, you are right, they are both inclusive and I Show quoted text On 2015/12/03 02:24:32, yoshiki wrote: > This is the max value, so you may specify "NUM_SCALE_FACTORS - 1"? Yes, you are right, they are both inclusive and I had wrong understanding. Will fix in the next CL or at separate CL. 565065 is reported for this. Thanks for attention!
	12

	13 IPC_STRUCT_TRAITS_BEGIN(arc::AppInfo)

	14 IPC_STRUCT_TRAITS_MEMBER(name)

	15 IPC_STRUCT_TRAITS_MEMBER(package)

	16 IPC_STRUCT_TRAITS_MEMBER(activity)

	17 IPC_STRUCT_TRAITS_END()

OLD	NEW