arc-bridge: Implement IPC message for app launcher

components/arc/arc_bridge_service.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_ARC_BRIDGE_SERVICE_H_
 #define COMPONENTS_ARC_ARC_BRIDGE_SERVICE_H_
 
 #include "base/files/scoped_file.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 46 matching lines @@
     STARTING,
 
     // The ARC instance has been fully initialized and is now ready for user
     // interaction.
     READY,
 
     // The ARC instance has started shutting down.
     STOPPING,
   };
 
+  // Notifies life cycle events of ArcBridgeService.
   class Observer {
    public:
     // Called whenever the state of the bridge has changed.
     virtual void OnStateChanged(State state) {}
 
     // Called when the instance has reached a boot phase
     virtual void OnInstanceBootPhase(InstanceBootPhase phase) {}
 
     // Called whenever ARC's availability has changed for this system.
     virtual void OnAvailableChanged(bool available) {}
 
    protected:
     virtual ~Observer() {}
   };
 
+  // Notifies ARC apps related events.
+  class AppsObserver {

[hidehiko, 2015/12/01 08:18:25]

nit: I prefer AppObserver, as this also receives individual app icon update
(OnAppIcon). WDYT?

[khmel1, 2015/12/01 09:49:32]

Sounds better, thanks

+  public:

[hidehiko, 2015/12/01 08:18:25]

nit: indent.

[khmel1, 2015/12/01 09:49:32]

Done.

+    // Called whenever ARC sends information about available apps.
+    virtual void OnAppsRefreshed(const std::vector<AppInfo>& apps) {}
+
+    // Called whenever ARC sends app icon data for specific scale factor.
+    virtual void OnAppIcon(const std::string& package,
+                           const std::string& activity,
+                           int scale_factor,
+                           const std::vector<uint8_t>& icon_png_data) {}
+
+   protected:
+    virtual ~AppsObserver() {}
+  };
+
   virtual ~ArcBridgeService();
 
   // Creates instance of |ArcBridgeService| for normal use.
   static scoped_ptr<ArcBridgeService> Create(
       const scoped_refptr<base::SingleThreadTaskRunner>& ipc_task_runner,
       const scoped_refptr<base::SequencedTaskRunner>& file_task_runner);
 
   // Gets the global instance of the ARC Bridge Service. This can only be
   // called on the thread that this class was created on.
   static ArcBridgeService* Get();
@@ skipping 14 matching lines @@
 
   // Shutdown() should be called when the browser is shutting down. This can
   // only be called on the thread that this class was created on.
   virtual void Shutdown() = 0;
 
   // Adds or removes observers. This can only be called on the thread that this
   // class was created on.
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
+  // Adds or removes ARC apps observers. This can only be called on the thread
+  // that this class was created on.
+  void AddAppsObserver(AppsObserver* observer);
+  void RemoveAppsObserver(AppsObserver* observer);
+
   // Gets the current state of the bridge service.
   State state() const { return state_; }
 
   // Gets if ARC is available in this system.
   bool available() const { return available_; }
 
   // Requests registration of an input device on the ARC instance.
   // TODO(denniskempin): Make this interface more typesafe.
   // |name| should be the displayable name of the emulated device (e.g. "Chrome
   // OS Keyboard"), |device_type| the name of the device type (e.g. "keyboard")
   // and |fd| a file descriptor that emulates the kernel events of the device.
   // This can only be called on the thread that this class was created on.
   virtual bool RegisterInputDevice(const std::string& name,
                                    const std::string& device_type,
                                    base::ScopedFD fd) = 0;
 
+  // Requests to refresh an app list.
+  virtual bool RefreshApps() = 0;

[hidehiko, 2015/12/01 08:18:25]

nit: Then, as you've written, how about name it RefereshAppList()?
IMHO, it is slightly clear that this refreshes a list of currently installed
applications, but does not refresh all applications running etc. WDYT?

[khmel1, 2015/12/01 09:49:32]

Agree

+
+  // Requests to launch an app.
+  virtual bool LaunchApp(const std::string& package,
+                         const std::string& activity) = 0;
+
+  // Request to load icon of specific scale_factor.
+  virtual bool RequestIcon(const std::string& package,
+                           const std::string& activity,
+                           int scale_factor) = 0;
+
  protected:
   ArcBridgeService();
 
   // Changes the current state and notifies all observers.
   void SetState(State state);
 
   // Changes the current availability and notifies all observers.
   void SetAvailable(bool availability);
 
   const scoped_refptr<base::SequencedTaskRunner>& origin_task_runner() const {
     return origin_task_runner_;
   }
 
   base::ObserverList<Observer>& observer_list() { return observer_list_; }
 
+  base::ObserverList<AppsObserver>& apps_observer_list() {
+    return apps_observer_list_;
+  }
+
  private:
   scoped_refptr<base::SequencedTaskRunner> origin_task_runner_;
 
   base::ObserverList<Observer> observer_list_;
 
+  base::ObserverList<AppsObserver> apps_observer_list_;
+
   // If the ARC instance service is available.
   bool available_;
 
   // The current state of the bridge.
   ArcBridgeService::State state_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcBridgeService);
 };
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_ARC_BRIDGE_SERVICE_H_