Remove ScopedVector from CreateSockets

Remove ScopedVector from CreateSockets

BUG=554289
Committed: https://crrev.com/d8734f2c779edb72b9a9062c93490e6e00f5273a
Cr-Commit-Position: refs/heads/master@{#362960}

[Olli Raula, 2015-11-24 09:13:45]

Description was changed from

==========
Remove ScopedVector from CreateSockets

BUG=554289
==========

to

==========
Remove ScopedVector from CreateSockets

BUG=554289
==========

[Olli Raula, 2015-11-24 09:13:45]

olli.raula@intel.com changed reviewers:
+ mmenke@chromium.org

[Olli Raula, 2015-11-24 09:17:07]

olli.raula@intel.com changed reviewers:
+ vitalybuka@chromium.org

[Olli Raula, 2015-11-24 09:17:54]

Could you review? mmenke: net vitalybuka chrome

[mmenke, 2015-11-24 17:39:34]

https://codereview.chromium.org/1475553002/diff/1/chrome/browser/local_discov...
File chrome/browser/local_discovery/service_discovery_client_mdns.cc (right):

https://codereview.chromium.org/1475553002/diff/1/chrome/browser/local_discov...
chrome/browser/local_discovery/service_discovery_client_mdns.cc:8: #include
"base/memory/scoped_vector.h"
Remove, include scoped_ptr, vector instead.

https://codereview.chromium.org/1475553002/diff/1/chrome/utility/local_discov...
File chrome/utility/local_discovery/service_discovery_message_handler.cc
(right):

https://codereview.chromium.org/1475553002/diff/1/chrome/utility/local_discov...
chrome/utility/local_discovery/service_discovery_message_handler.cc:84:
std::vector<scoped_ptr<net::DatagramServerSocket>>* sockets) override {
include vector / scoped_ptr (At least in net, we generally try to include the
transitive dependencies we use directly, even when needed just to declare a
method we're overriding)

https://codereview.chromium.org/1475553002/diff/1/net/dns/mdns_client.h
File net/dns/mdns_client.h (right):

https://codereview.chromium.org/1475553002/diff/1/net/dns/mdns_client.h#newco...
net/dns/mdns_client.h:132: std::vector<scoped_ptr<DatagramServerSocket>>*
sockets) = 0;
include scoped_ptr (Yea, should have been included already, but isn't)

https://codereview.chromium.org/1475553002/diff/1/net/dns/mdns_client_impl.cc
File net/dns/mdns_client_impl.cc (right):

https://codereview.chromium.org/1475553002/diff/1/net/dns/mdns_client_impl.cc...
net/dns/mdns_client_impl.cc:177: for (auto& it : socket_handlers_) {
const?  Not that it gets us a whole lot here.

https://codereview.chromium.org/1475553002/diff/1/net/dns/mdns_client_impl.cc...
net/dns/mdns_client_impl.cc:180: }
nit:  Don't use braces for two-line ifs.

https://codereview.chromium.org/1475553002/diff/1/net/dns/mdns_client_impl.h
File net/dns/mdns_client_impl.h (right):

https://codereview.chromium.org/1475553002/diff/1/net/dns/mdns_client_impl.h#...
net/dns/mdns_client_impl.h:38: std::vector<scoped_ptr<DatagramServerSocket>>*
sockets) override;
include scoped_ptr

https://codereview.chromium.org/1475553002/diff/1/net/dns/mdns_client_unittes...
File net/dns/mdns_client_unittest.cc (right):

https://codereview.chromium.org/1475553002/diff/1/net/dns/mdns_client_unittes...
net/dns/mdns_client_unittest.cc:1161:
std::vector<scoped_ptr<DatagramServerSocket>>* sockets) override {
include vector, scoped_ptr

https://codereview.chromium.org/1475553002/diff/1/net/dns/mock_mdns_socket_fa...
File net/dns/mock_mdns_socket_factory.h (right):

https://codereview.chromium.org/1475553002/diff/1/net/dns/mock_mdns_socket_fa...
net/dns/mock_mdns_socket_factory.h:80:
std::vector<scoped_ptr<DatagramServerSocket>>* sockets) override;
include vector, scoped_ptr/.  Hrm...This file does rather violate the general
policy of net mentioned earlier.

https://codereview.chromium.org/1475553002/diff/1/net/url_request/url_request...
File net/url_request/url_request_throttler_simulation_unittest.cc (right):

https://codereview.chromium.org/1475553002/diff/1/net/url_request/url_request...
net/url_request/url_request_throttler_simulation_unittest.cc:491:
std::vector<scoped_ptr<Requester>> requesters;
This change really doesn't seem to belong in this CL - fine with grouping
changes in related files, but mdns and this file doesn't seem to have anything
in common.

[Olli Raula, 2015-11-26 12:46:13]

Thanks, fixed

[mmenke, 2015-11-30 20:36:45]

LGTM!

https://codereview.chromium.org/1475553002/diff/40001/net/dns/mdns_client_uni...
File net/dns/mdns_client_unittest.cc (right):

https://codereview.chromium.org/1475553002/diff/40001/net/dns/mdns_client_uni...
net/dns/mdns_client_unittest.cc:1162:
std::vector<scoped_ptr<DatagramServerSocket>>* sockets) override {
include <vector>

[Olli Raula, 2015-12-02 07:49:25]

Vitaly Buka, ping!

[Vitaly Buka (NO REVIEWS), 2015-12-02 18:32:10]

lgtm

https://codereview.chromium.org/1475553002/diff/60001/chrome/utility/local_di...
File chrome/utility/local_discovery/service_discovery_message_handler.cc
(right):

https://codereview.chromium.org/1475553002/diff/60001/chrome/utility/local_di...
chrome/utility/local_discovery/service_discovery_message_handler.cc:78: for
(scoped_ptr<net::DatagramServerSocket>& it : sockets_) {
use of {} is inconsistent with the rest of the file

[Olli Raula, 2015-12-03 11:04:41]

The CQ bit was checked by olli.raula@intel.com

[Olli Raula, 2015-12-03 11:04:41]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org,
vitalybuka@chromium.org
Link to the patchset: https://codereview.chromium.org/1475553002/#ps80001
(title: "Remove {}")

[commit-bot: I haz the power, 2015-12-03 11:04:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1475553002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1475553002/80001

[commit-bot: I haz the power, 2015-12-03 12:37:46]

Description was changed from

==========
Remove ScopedVector from CreateSockets

BUG=554289
==========

to

==========
Remove ScopedVector from CreateSockets

BUG=554289
==========

[commit-bot: I haz the power, 2015-12-03 12:37:47]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-03 12:38:54]

Description was changed from

==========
Remove ScopedVector from CreateSockets

BUG=554289
==========

to

==========
Remove ScopedVector from CreateSockets

BUG=554289

Committed: https://crrev.com/d8734f2c779edb72b9a9062c93490e6e00f5273a
Cr-Commit-Position: refs/heads/master@{#362960}
==========

[commit-bot: I haz the power, 2015-12-03 12:38:55]

Patchset 5 (id:??) landed as
https://crrev.com/d8734f2c779edb72b9a9062c93490e6e00f5273a
Cr-Commit-Position: refs/heads/master@{#362960}