Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1475543004: Revert of Fix Win GN dbg build missing powrprof.lib (Closed)

Created:
5 years ago by scottmg
Modified:
5 years ago
Reviewers:
Mark Mentovai, raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix Win GN dbg build missing powrprof.lib (patchset #1 id:1 of https://codereview.chromium.org/1473513007/ ) Reason for revert: Some failing tests https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/43485. Unclear why they didn't fail on trybots so I'm going to revert and investigate. Original issue's description: > Fix Win GN dbg build missing powrprof.lib > > TBR=raymes@chromium.org > BUG=546288 > > Committed: https://chromium.googlesource.com/chromium/src/+/d01d3720730602fdc8aeb19aa0b19ed6c5a5849c TBR=raymes@chromium.org,mark@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=546288 Committed: https://crrev.com/f170638b5c333ef8220ff6ee7836efef7452ebd3 Cr-Commit-Position: refs/heads/master@{#361796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/secondary/third_party/crashpad/crashpad/snapshot/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
Created Revert of Fix Win GN dbg build missing powrprof.lib
5 years ago (2015-11-26 02:19:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475543004/1
5 years ago (2015-11-26 02:20:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 02:22:52 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f170638b5c333ef8220ff6ee7836efef7452ebd3 Cr-Commit-Position: refs/heads/master@{#361796}
5 years ago (2015-11-26 02:24:10 UTC) #5
Mark Mentovai
5 years ago (2015-11-26 04:51:52 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698