Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 1475523002: X87: Make arguments adaptor not clobber new.target. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Make arguments adaptor not clobber new.target. port c1e7c8d972e8a42878dcae6bf1ad33997608e7b3 (r32171) original commit message: This ensures that the ArgumentsAdaptorTrampoline does not clobber the new.target value, but rather passes it through to the callee unaltered. Note that callees do not yet use the new.target value so far. This is a preparatory CL to allows us passing new.target in a register instead of via a side-channel through the construct stub frame. BUG= Committed: https://crrev.com/84010cb2c7ab7fa6960e03a1444df4c246906aa3 Cr-Commit-Position: refs/heads/master@{#32192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M src/x87/builtins-x87.cc View 6 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-24 02:50:26 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-24 03:25:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475523002/1
5 years, 1 month ago (2015-11-24 03:26:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-24 07:03:35 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/84010cb2c7ab7fa6960e03a1444df4c246906aa3 Cr-Commit-Position: refs/heads/master@{#32192}
5 years, 1 month ago (2015-11-24 07:03:50 UTC) #7
Michael Starzinger
5 years ago (2015-11-24 08:57:03 UTC) #8
Message was sent while issue was closed.
LGTM. Thanks!

Powered by Google App Engine
This is Rietveld 408576698