pkg/compiler/lib/src/js_backend/codegen/codegen.dart - Issue 1475513009: Revert "dart2js cps: Add CharCodeAt builtin."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1475513009: Revert "dart2js cps: Add CharCodeAt builtin." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

index 26800caccde428964cf9c8249069cc8b46a6846b..bcf09683b88188eb9cd796c250bc132d3264e51d 100644

--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

@@ -949,8 +949,6 @@ class CodeGenerator extends tree_ir.StatementVisitor

case BuiltinOperator.StringConcatenate:

if (args.isEmpty) return js.string('');

return args.reduce((e1,e2) => new js.Binary('+', e1, e2));

- case BuiltinOperator.CharCodeAt:

- return js.js('#.charCodeAt(#)', args);

case BuiltinOperator.Identical:

registry.registerStaticUse(new StaticUse.staticInvoke(

glue.identicalFunction, new CallStructure.unnamed(args.length)));