Issue 1475513009: Revert "dart2js cps: Add CharCodeAt builtin."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1475513009: Revert "dart2js cps: Add CharCodeAt builtin." (Closed)

Created:
5 years ago by sra1

Modified:
5 years ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "dart2js cps: Add CharCodeAt builtin." This test fails: tools/test.py -mrelease -cdart2js -rd8 --cps-ir language/invocation_mirror_invoke_on2_test The reason is unrelated: because String.codeUnitAt, the only reference is the call on Proxy. There appears to be a bug with recognizing this. TBR=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/6db18cbbd8a68abe1b42715110943cc4f2c65190

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -110 lines)			Patch
M	pkg/compiler/lib/src/common/names.dart	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/builtin_operator.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View	4 chunks	+7 lines, -49 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/types/type_mask.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
D	tests/compiler/dart2js/js_backend_cps_ir_codeUnitAt_test.dart	View	1 chunk	+0 lines, -46 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sra1

5 years ago (2015-11-26 01:44:18 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6db18cbbd8a68abe1b42715110943cc4f2c65190 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages