New build flag system, convert Google Now flag

New build flag system, convert Google Now flag

This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.

Converts Google Now to use this and remove the global google now define and grit define.

Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").

Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.

Reland of https://codereview.chromium.org/1458653002/
TBR=mark@chromium.org

Committed: https://crrev.com/cbc1cd295bc85219ad89326457cd7f5cf003d41c
Cr-Commit-Position: refs/heads/master@{#361741}

[brettw, 2015-11-25 18:51:45]

Patch set 1 is the original landing. The new one adds hard dependency flags to
common_constants and chrome_common because too many targets depend transitively
on the generated header to keep up-to-date easily.

[brettw, 2015-11-25 18:51:58]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-25 18:53:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1475513006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1475513006/20001

[Mark Mentovai, 2015-11-25 19:04:40]

LGTM

[commit-bot: I haz the power, 2015-11-25 21:52:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-25 21:53:35]

Description was changed from

==========
New build flag system, convert Google Now flag

This generates headers with build flags rather than forcing them all to be
global. It includes an accessor wrapper so that references to the flags will
fail if the proper header is not included.

Converts Google Now to use this and remove the global google now define and grit
define.

Adds support for grit define values of "true" and "false" for ease of
integration with GN (they are mapped to the corresponding Python "True" and
"False").

Adds dependencies from the main gyp targets to the new generated feature define
target. Since GYP only does hard dependencies one level, this should reduce the
chance that somebody adds more of these cases and forces to add a dependency.

Reland of https://codereview.chromium.org/1458653002/
TBR=mark@chromium.org
==========

to

==========
New build flag system, convert Google Now flag

This generates headers with build flags rather than forcing them all to be
global. It includes an accessor wrapper so that references to the flags will
fail if the proper header is not included.

Converts Google Now to use this and remove the global google now define and grit
define.

Adds support for grit define values of "true" and "false" for ease of
integration with GN (they are mapped to the corresponding Python "True" and
"False").

Adds dependencies from the main gyp targets to the new generated feature define
target. Since GYP only does hard dependencies one level, this should reduce the
chance that somebody adds more of these cases and forces to add a dependency.

Reland of https://codereview.chromium.org/1458653002/
TBR=mark@chromium.org

Committed: https://crrev.com/cbc1cd295bc85219ad89326457cd7f5cf003d41c
Cr-Commit-Position: refs/heads/master@{#361741}
==========

[commit-bot: I haz the power, 2015-11-25 21:53:36]

Patchset 2 (id:??) landed as
https://crrev.com/cbc1cd295bc85219ad89326457cd7f5cf003d41c
Cr-Commit-Position: refs/heads/master@{#361741}

[brettw, 2015-11-25 22:20:27]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1480693003/ by brettw@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Bu....