Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14755002: drive: Drop "Drive" from FakeDriveFileSystem and MockDriveFileSystem (Closed)

Created:
7 years, 7 months ago by satorux1
Modified:
7 years, 7 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Drop "Drive" from FakeDriveFileSystem and MockDriveFileSystem As part of an effort to remove 'drive' prefix from c/b/chromeos/drive. Along the way, remove some 'drive' prefix from code inside the drive direcotry. BUG=231807 TEST=none R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197582

Patch Set 1 : #

Patch Set 2 : some more cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -1340 lines) Patch
M chrome/browser/chromeos/drive/download_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_stream_reader.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_stream_reader.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc View 1 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_protocol_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_system_service_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_url_request_job.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_url_request_job.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_url_request_job_unittest.cc View 1 8 chunks +14 lines, -14 lines 0 comments Download
D chrome/browser/chromeos/drive/fake_drive_file_system.h View 1 chunk +0 lines, -244 lines 0 comments Download
D chrome/browser/chromeos/drive/fake_drive_file_system.cc View 1 chunk +0 lines, -497 lines 0 comments Download
D chrome/browser/chromeos/drive/fake_drive_file_system_unittest.cc View 1 chunk +0 lines, -222 lines 0 comments Download
A + chrome/browser/chromeos/drive/fake_file_system.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/chromeos/drive/fake_file_system.cc View 18 chunks +73 lines, -73 lines 0 comments Download
A + chrome/browser/chromeos/drive/fake_file_system_unittest.cc View 1 14 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_file_operation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_file_operation.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/drive_operations.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/drive_operations.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_proxy.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_proxy.cc View 1 19 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util_unittest.cc View 1 10 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/drive/file_write_helper_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/chromeos/drive/mock_drive_file_system.h View 1 chunk +0 lines, -127 lines 0 comments Download
D chrome/browser/chromeos/drive/mock_drive_file_system.cc View 1 chunk +0 lines, -15 lines 0 comments Download
A + chrome/browser/chromeos/drive/mock_file_system.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/chromeos/drive/mock_file_system.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
satorux1
7 years, 7 months ago (2013-05-01 05:47:29 UTC) #1
kinaba
lgtm
7 years, 7 months ago (2013-05-01 06:31:09 UTC) #2
satorux1
please take a look at patch set 2. did some more cleanup
7 years, 7 months ago (2013-05-01 06:47:03 UTC) #3
kinaba
lgtm
7 years, 7 months ago (2013-05-01 07:07:40 UTC) #4
satorux1
7 years, 7 months ago (2013-05-01 07:20:37 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r197582 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698