Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Issue 1475493002: Enable MinorGCUnmodifiedWrapperVisitor in workers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2564
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
index dfb81dacb349b438f8f18604c8ee02fc1ef7be4a..c3b4cc8eb022f32066119c36b08e2de4fc941a77 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
@@ -245,7 +245,6 @@ namespace {
void visitWeakHandlesForMinorGC(v8::Isolate* isolate)
{
- ASSERT(isMainThread());
MinorGCUnmodifiedWrapperVisitor visitor(isolate);
isolate->VisitWeakHandles(&visitor);
}
@@ -290,10 +289,10 @@ void V8GCController::gcPrologue(v8::GCType type, v8::GCCallbackFlags flags)
case v8::kGCTypeScavenge:
TRACE_EVENT_BEGIN1("devtools.timeline,v8", "MinorGC", "usedHeapSizeBefore", usedHeapSize(isolate));
if (isMainThread()) {
- {
- TRACE_EVENT_SCOPED_SAMPLING_STATE("blink", "DOMMinorGC");
- visitWeakHandlesForMinorGC(isolate);
- }
+ TRACE_EVENT_SCOPED_SAMPLING_STATE("blink", "DOMMinorGC");
+ }
+ visitWeakHandlesForMinorGC(isolate);
+ if (isMainThread()) {
V8PerIsolateData::from(isolate)->setPreviousSamplingState(TRACE_EVENT_GET_SAMPLING_STATE());
TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8MinorGC");
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698