Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1475483002: Add an MB config for the blimp_engine official builder. (Closed)

Created:
5 years ago by Dirk Pranke
Modified:
5 years ago
Reviewers:
Wez, amineer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an MB config for the blimp_engine official builder. R=amineer@chromium.org, wez@chromium.org BUG= Committed: https://crrev.com/a4217fb00e126ea5340b9a61522b7ccbb3b9713d Cr-Commit-Position: refs/heads/master@{#361257}

Patch Set 1 #

Patch Set 2 : add comments/rationale for the blimp config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M tools/mb/mb_config.pyl View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
Dirk Pranke
Alex, please take a look. This is different from your test CL, in the following ...
5 years ago (2015-11-24 00:56:48 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475483002/1
5 years ago (2015-11-24 00:59:10 UTC) #3
Wez
LGTM but I'd prefer that the rationale text from your message to Alex, explaining why ...
5 years ago (2015-11-24 01:32:43 UTC) #4
Dirk Pranke
On 2015/11/24 01:32:43, Wez wrote: > LGTM but I'd prefer that the rationale text from ...
5 years ago (2015-11-24 01:33:51 UTC) #5
Dirk Pranke
On 2015/11/24 01:33:51, Dirk Pranke wrote: > On 2015/11/24 01:32:43, Wez wrote: > > LGTM ...
5 years ago (2015-11-24 01:36:47 UTC) #6
Wez
On 2015/11/24 at 01:36:47, dpranke wrote: > On 2015/11/24 01:33:51, Dirk Pranke wrote: > > ...
5 years ago (2015-11-24 01:50:37 UTC) #7
Dirk Pranke
On 2015/11/24 01:50:37, Wez wrote: > If you prefer to use a comment rather than ...
5 years ago (2015-11-24 02:00:21 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475483002/20001
5 years ago (2015-11-24 02:09:24 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-24 04:51:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475483002/20001
5 years ago (2015-11-24 05:07:39 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-24 05:14:25 UTC) #15
commit-bot: I haz the power
5 years ago (2015-11-24 05:15:27 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a4217fb00e126ea5340b9a61522b7ccbb3b9713d
Cr-Commit-Position: refs/heads/master@{#361257}

Powered by Google App Engine
This is Rietveld 408576698