Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: content/browser/frame_host/frame_tree_browsertest.cc

Issue 1475433002: Expose RenderFrameHost::GetLastCommittedOrigin(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Charlie's fixes. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/frame_tree_browsertest.cc
diff --git a/content/browser/frame_host/frame_tree_browsertest.cc b/content/browser/frame_host/frame_tree_browsertest.cc
index f64e22733db5b3dfe059febad28daa4e5dc797b6..f68b6b43381a532e1c3291959c7bc93d7604e04b 100644
--- a/content/browser/frame_host/frame_tree_browsertest.cc
+++ b/content/browser/frame_host/frame_tree_browsertest.cc
@@ -19,6 +19,7 @@
#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "third_party/WebKit/public/web/WebSandboxFlags.h"
+#include "url/url_constants.h"
// For fine-grained suppression on flaky tests.
#if defined(OS_WIN)
@@ -37,6 +38,15 @@ class FrameTreeBrowserTest : public ContentBrowserTest {
SetupCrossSiteRedirector(embedded_test_server());
}
+ protected:
+ std::string GetOriginFromRenderer(FrameTreeNode* node) {
+ std::string origin;
+ EXPECT_TRUE(ExecuteScriptAndExtractString(
+ node->current_frame_host(),
+ "window.domAutomationController.send(document.origin);", &origin));
+ return origin;
+ }
+
private:
DISALLOW_COPY_AND_ASSIGN(FrameTreeBrowserTest);
};
@@ -205,36 +215,82 @@ IN_PROC_BROWSER_TEST_F(FrameTreeBrowserTest, IsRenderFrameLive) {
// Ensure that origins are correctly set on navigations.
IN_PROC_BROWSER_TEST_F(FrameTreeBrowserTest, OriginSetOnNavigation) {
- GURL main_url(embedded_test_server()->GetURL("/frame_tree/top.html"));
+ GURL about_blank(url::kAboutBlankURL);
+ GURL main_url(
+ embedded_test_server()->GetURL("a.com", "/frame_tree/top.html"));
EXPECT_TRUE(NavigateToURL(shell(), main_url));
+ WebContents* contents = shell()->web_contents();
// It is safe to obtain the root frame tree node here, as it doesn't change.
- FrameTreeNode* root = static_cast<WebContentsImpl*>(shell()->web_contents())
- ->GetFrameTree()->root();
+ FrameTreeNode* root =
+ static_cast<WebContentsImpl*>(contents)->GetFrameTree()->root();
// Extra '/' is added because the replicated origin is serialized in RFC 6454
// format, which dictates no trailing '/', whereas GURL::GetOrigin does put a
// '/' at the end.
- EXPECT_EQ(root->current_origin().Serialize() + '/',
- main_url.GetOrigin().spec());
+ EXPECT_EQ(main_url.GetOrigin().spec(),
+ root->current_origin().Serialize() + '/');
+ EXPECT_EQ(
+ main_url.GetOrigin().spec(),
+ root->current_frame_host()->GetLastCommittedOrigin().Serialize() + '/');
- GURL frame_url(embedded_test_server()->GetURL("/title1.html"));
+ // The iframe is inititially same-origin.
+ EXPECT_TRUE(
+ root->current_frame_host()->GetLastCommittedOrigin().IsSameOriginWith(
+ root->child_at(0)->current_frame_host()->GetLastCommittedOrigin()));
+ EXPECT_EQ(root->current_origin().Serialize(), GetOriginFromRenderer(root));
+ EXPECT_EQ(root->child_at(0)->current_origin().Serialize(),
+ GetOriginFromRenderer(root->child_at(0)));
+
+ // Navigate the iframe cross-origin.
+ GURL frame_url(embedded_test_server()->GetURL("b.com", "/title1.html"));
NavigateFrameToURL(root->child_at(0), frame_url);
-
- EXPECT_EQ(root->child_at(0)->current_origin().Serialize() + '/',
- frame_url.GetOrigin().spec());
+ EXPECT_EQ(frame_url, root->child_at(0)->current_url());
+ EXPECT_EQ(frame_url.GetOrigin().spec(),
+ root->child_at(0)->current_origin().Serialize() + '/');
+ EXPECT_FALSE(
+ root->current_frame_host()->GetLastCommittedOrigin().IsSameOriginWith(
+ root->child_at(0)->current_frame_host()->GetLastCommittedOrigin()));
+ EXPECT_EQ(root->current_origin().Serialize(), GetOriginFromRenderer(root));
+ EXPECT_EQ(root->child_at(0)->current_origin().Serialize(),
+ GetOriginFromRenderer(root->child_at(0)));
+
+ // Parent-initiated about:blank navigation should inherit the parent's a.com
+ // origin.
+ NavigateIframeToURL(contents, "1-1-id", about_blank);
+ EXPECT_EQ(about_blank, root->child_at(0)->current_url());
+ EXPECT_EQ(main_url.GetOrigin().spec(),
+ root->child_at(0)->current_origin().Serialize() + '/');
+ EXPECT_EQ(root->current_frame_host()->GetLastCommittedOrigin().Serialize(),
+ root->child_at(0)
+ ->current_frame_host()
+ ->GetLastCommittedOrigin()
+ .Serialize());
+ EXPECT_TRUE(
+ root->current_frame_host()->GetLastCommittedOrigin().IsSameOriginWith(
+ root->child_at(0)->current_frame_host()->GetLastCommittedOrigin()));
+ EXPECT_EQ(root->current_origin().Serialize(), GetOriginFromRenderer(root));
+ EXPECT_EQ(root->child_at(0)->current_origin().Serialize(),
+ GetOriginFromRenderer(root->child_at(0)));
GURL data_url("data:text/html,foo");
EXPECT_TRUE(NavigateToURL(shell(), data_url));
// Navigating to a data URL should set a unique origin. This is represented
// as "null" per RFC 6454.
- EXPECT_EQ(root->current_origin().Serialize(), "null");
+ EXPECT_EQ("null", root->current_origin().Serialize());
+ EXPECT_TRUE(contents->GetMainFrame()->GetLastCommittedOrigin().unique());
+ EXPECT_EQ("null", GetOriginFromRenderer(root));
// Re-navigating to a normal URL should update the origin.
EXPECT_TRUE(NavigateToURL(shell(), main_url));
- EXPECT_EQ(root->current_origin().Serialize() + '/',
- main_url.GetOrigin().spec());
+ EXPECT_EQ(main_url.GetOrigin().spec(),
+ root->current_origin().Serialize() + '/');
+ EXPECT_EQ(
+ main_url.GetOrigin().spec(),
+ contents->GetMainFrame()->GetLastCommittedOrigin().Serialize() + '/');
+ EXPECT_FALSE(contents->GetMainFrame()->GetLastCommittedOrigin().unique());
+ EXPECT_EQ(root->current_origin().Serialize(), GetOriginFromRenderer(root));
}
// Ensure that sandbox flags are correctly set when child frames are created.
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698