Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 147543004: [Geolocation] Add permission bubble client. (Closed)

Created:
6 years, 10 months ago by Greg Billock
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Michael van Ouwerkerk
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : lint #

Patch Set 3 : Rebase #

Patch Set 4 : Add cancellation TODO #

Patch Set 5 : Fix android, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -19 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context.h View 3 chunks +15 lines, -10 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context.cc View 1 2 3 7 chunks +103 lines, -6 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context_android.h View 1 2 3 4 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context_android.cc View 1 2 3 4 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Greg Billock
6 years, 10 months ago (2014-02-01 01:42:12 UTC) #1
timvolodine
looks ok to me, but please get an lgtm from Michael as he is the ...
6 years, 10 months ago (2014-02-05 12:26:14 UTC) #2
Greg Billock
https://codereview.chromium.org/147543004/diff/1/chrome/browser/geolocation/chrome_geolocation_permission_context.cc File chrome/browser/geolocation/chrome_geolocation_permission_context.cc (right): https://codereview.chromium.org/147543004/diff/1/chrome/browser/geolocation/chrome_geolocation_permission_context.cc#newcode40 chrome/browser/geolocation/chrome_geolocation_permission_context.cc:40: ChromeGeolocationPermissionContext* context, On 2014/02/05 12:26:15, timvolodine wrote: > indent ...
6 years, 10 months ago (2014-02-05 16:46:37 UTC) #3
Michael van Ouwerkerk
lgtm
6 years, 10 months ago (2014-02-06 13:10:25 UTC) #4
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 10 months ago (2014-02-06 18:37:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/147543004/130001
6 years, 10 months ago (2014-02-06 18:38:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 19:49:02 UTC) #7
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=45868
6 years, 10 months ago (2014-02-06 19:49:04 UTC) #8
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 10 months ago (2014-02-06 20:45:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/147543004/130001
6 years, 10 months ago (2014-02-06 20:48:41 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 22:13:35 UTC) #11
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=113272
6 years, 10 months ago (2014-02-06 22:13:36 UTC) #12
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 10 months ago (2014-02-11 05:10:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/147543004/550001
6 years, 10 months ago (2014-02-11 05:10:43 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 13:48:26 UTC) #15
Message was sent while issue was closed. 
Change committed as 250380

Powered by Google App Engine
This is Rietveld 408576698