Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1475353002: disassembler_x86: Remove unused include (Closed)

Created:
5 years ago by labath
Modified:
4 years, 11 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

disassembler_x86: Remove unused include This file is not present on windows, and it's causing build errors there. As far as I can tell, nothing in this file actually uses that include, so I just remove it. BUG= R=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/1979e591078cb700fd4ccff888780fec0a6b5189

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/processor/disassembler_x86.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
labath
4 years, 11 months ago (2016-01-08 13:13:37 UTC) #4
Mark Mentovai
LGTM
4 years, 11 months ago (2016-01-08 14:12:03 UTC) #5
labath
Thanks. I don't think I am able to submit this (if there is a way, ...
4 years, 11 months ago (2016-01-08 14:59:48 UTC) #6
Mark Mentovai
4 years, 11 months ago (2016-01-08 15:07:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1979e591078cb700fd4ccff888780fec0a6b5189 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698