Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 1475343002: Revert of [turbofan] Implemented the TruncateFloat32ToInt64 TurboFan operator. (Closed)

Created:
5 years ago by ahaas
Modified:
5 years ago
Reviewers:
titzer, v8-mips-ports, jbramley, Michael Achenbach
CC:
v8-reviews_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Implemented the TruncateFloat32ToInt64 TurboFan operator. (patchset #1 id:1 of https://codereview.chromium.org/1476063002/ ) Reason for revert: Unexpected error occurred. Original issue's description: > [turbofan] Implemented the TruncateFloat32ToInt64 TurboFan operator. > > The TruncateFloat32ToInt64 operator converts a float32 to an int64 using > the round-to-zero rounding mode (truncate). If the input value is > outside the int64 range, then the result depends on the architecture. I > implemented the operator on x64, arm64, and mips64. > > R=titzer@chromium.org, jacob.bramley@arm.com > > Committed: https://crrev.com/1df1066c3c77464d2a68d7c8d501a5a0f3ad195a > Cr-Commit-Position: refs/heads/master@{#32315} TBR=jacob.bramley@arm.com,titzer@chromium.org,v8-mips-ports@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a336404f618143408e5c7fd245577b800f065f3b Cr-Commit-Position: refs/heads/master@{#32316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -137 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ahaas
Created Revert of [turbofan] Implemented the TruncateFloat32ToInt64 TurboFan operator.
5 years ago (2015-11-26 09:01:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475343002/1
5 years ago (2015-11-26 09:01:13 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-11-26 09:01:16 UTC) #4
Michael Achenbach
lgtm
5 years ago (2015-11-26 09:05:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475343002/1
5 years ago (2015-11-26 09:05:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 09:05:54 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-26 09:06:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a336404f618143408e5c7fd245577b800f065f3b
Cr-Commit-Position: refs/heads/master@{#32316}

Powered by Google App Engine
This is Rietveld 408576698