components/autofill/content/common/autofill_messages.h - Issue 147533005: [Password Generation] Update UI to match final mocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 147533005: [Password Generation] Update UI to match final mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replace_password_generation_ui

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc ('K') | « chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc ('k') | components/autofill/content/renderer/password_generation_agent.cc » ('j') | ui/views/controls/styled_label.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index 54fd2504ec49f68737bde52d06e8a99fdd982c4e..3eb70c8fda9c85a75c132132dd25ef6abe14644e 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -241,9 +241,11 @@ IPC_MESSAGE_ROUTED3(AutofillHostMsg_ShowPasswordGenerationPopup,

autofill::PasswordForm)

// Instructs the browser to show the popup for editing a generated password.

-// The location should be specified in the renderers coordinate system.

-IPC_MESSAGE_ROUTED1(AutofillHostMsg_ShowPasswordEditingPopup,

- gfx::RectF /* source location */)

+// The location should be specified in the renderers coordinate system. Form

+// is the form associated with the password field.

+IPC_MESSAGE_ROUTED2(AutofillHostMsg_ShowPasswordEditingPopup,

+ gfx::RectF /* source location */,

+ autofill::PasswordForm)

// Instructs the browser to hide any password generation popups.

IPC_MESSAGE_ROUTED0(AutofillHostMsg_HidePasswordGenerationPopup)