Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5636)

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_controller.h

Issue 147533005: [Password Generation] Update UI to match final mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replace_password_generation_ui
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/password_generation_popup_controller.h
diff --git a/chrome/browser/ui/autofill/password_generation_popup_controller.h b/chrome/browser/ui/autofill/password_generation_popup_controller.h
index 91bbe9f42983ac18d99cdc63342c316f5996ef95..19ec048062f0facba2319bdc5e21fd00bfa4b808 100644
--- a/chrome/browser/ui/autofill/password_generation_popup_controller.h
+++ b/chrome/browser/ui/autofill/password_generation_popup_controller.h
@@ -8,32 +8,39 @@
#include "base/strings/string16.h"
#include "chrome/browser/ui/autofill/autofill_popup_view_delegate.h"
+namespace gfx {
+class FontList;
+}
+
namespace autofill {
class PasswordGenerationPopupController : public AutofillPopupViewDelegate {
public:
// Space above and below the password section.
- static const int kPasswordVerticalPadding = 14;
+ static const int kPasswordVerticalPadding = 16;
// Space above and below help section.
static const int kHelpVerticalPadding = 15;
// Spacing between the border of the popup and any text.
- static const int kHorizontalPadding = 9;
+ static const int kHorizontalPadding = 10;
- // Called by the view when the help link is clicked.
- virtual void OnHelpLinkClicked() = 0;
+ // Called by the view when the saved passwords link is clicked.
+ virtual void OnSavedPasswordsLinkClicked() = 0;
// Accessors
+ virtual const gfx::FontList& font_list() const = 0;
virtual const gfx::Rect& password_bounds() const = 0;
virtual const gfx::Rect& divider_bounds() const = 0;
virtual const gfx::Rect& help_bounds() const = 0;
+ virtual bool display_password() const = 0;
virtual bool password_selected() const = 0;
virtual base::string16 password() const = 0;
// Translated strings
+ virtual base::string16 SuggestedText() = 0;
virtual base::string16 HelpText() = 0;
- virtual base::string16 LearnMoreLink() = 0;
+ virtual base::string16 SavedPasswordsLink() = 0;
protected:
virtual ~PasswordGenerationPopupController() {}

Powered by Google App Engine
This is Rietveld 408576698