Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: chrome/browser/ui/views/autofill/password_generation_popup_view_views.h

Issue 147533005: [Password Generation] Update UI to match final mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replace_password_generation_ui
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/autofill/password_generation_popup_view_views.h
diff --git a/chrome/browser/ui/views/autofill/password_generation_popup_view_views.h b/chrome/browser/ui/views/autofill/password_generation_popup_view_views.h
index 9fe5d44824eda637852eeebfef32979328ce2852..28f07cc9f68b2bc83cd1d7d6a750ae4736a4624c 100644
--- a/chrome/browser/ui/views/autofill/password_generation_popup_view_views.h
+++ b/chrome/browser/ui/views/autofill/password_generation_popup_view_views.h
@@ -10,7 +10,8 @@
#include "ui/views/controls/styled_label_listener.h"
namespace views {
-class Label;
+class StyledLabel;
+class View;
}
namespace autofill {
@@ -29,20 +30,25 @@ class PasswordGenerationPopupViewViews : public AutofillPopupBaseView,
virtual void Show() OVERRIDE;
virtual void Hide() OVERRIDE;
virtual void UpdateBoundsAndRedrawPopup() OVERRIDE;
+ virtual void PasswordSelectionUpdated() OVERRIDE;
private:
virtual ~PasswordGenerationPopupViewViews();
+ // Helper function to create |password_view_|.
+ void CreatePasswordView();
+
// views:Views implementation.
+ virtual void Layout() OVERRIDE;
virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;
// views::StyledLabelListener implementation
virtual void StyledLabelLinkClicked(const gfx::Range& range,
int event_flags) OVERRIDE;
- // Label for the generated password. Used to change the background color when
- // the password is selected/deselected. Weak reference.
- views::Label* password_label_;
+ // Sub views. Used to change bounds when updating. Weak references.
+ views::View* password_view_;
+ views::StyledLabel* help_label_;
// Controller for this view. Weak reference.
PasswordGenerationPopupController* controller_;

Powered by Google App Engine
This is Rietveld 408576698