Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2539)

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_view.h

Issue 147533005: [Password Generation] Update UI to match final mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replace_password_generation_ui
Patch Set: Unittests Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/password_generation_popup_view.h
diff --git a/chrome/browser/ui/autofill/password_generation_popup_view.h b/chrome/browser/ui/autofill/password_generation_popup_view.h
index db895a4d85428bb93447cbc7e1da7f2d1ebc1f5d..eb4ee00efc905e76835f266008d28f863630c671 100644
--- a/chrome/browser/ui/autofill/password_generation_popup_view.h
+++ b/chrome/browser/ui/autofill/password_generation_popup_view.h
@@ -12,6 +12,11 @@ class PasswordGenerationPopupController;
// Interface for creating and controlling a platform dependent view.
class PasswordGenerationPopupView {
public:
+ // This is the amount of vertical whitespace that is left above and below the
+ // password when it is highlighted.
+ static const int kPasswordVerticalInset = 7;
+
+ // Display the popup.
virtual void Show() = 0;
// This will cause the popup to be deleted.
@@ -20,6 +25,9 @@ class PasswordGenerationPopupView {
// Updates layout information from the controller.
virtual void UpdateBoundsAndRedrawPopup() = 0;
+ // Called when the password selection state has changed.
+ virtual void PasswordSelectionUpdated() = 0;
+
// Note that PasswordGenerationPopupView owns itself, and will only be deleted
// when Hide() is called.
static PasswordGenerationPopupView* Create(

Powered by Google App Engine
This is Rietveld 408576698